Fix algorithm names in GenerateSecret tests - #1722
Open
jasonkatonica wants to merge 1 commit into
Open
Conversation
BaseTestECDH.test_engineGenerateSecret and BaseTestXDH.test_engineGenerateSecret were using "DH" for both KeyPairGenerator and KeyAgreement instead of the correct algorithm names "ECDH" and "XDH" respectively. This caused the tests to exercise the wrong key agreement algorithm rather than the one under test. Fixes: IBM#1721 Signed-off-by: Jason Katonica <katonica@us.ibm.com>
jasonkatonica
requested review from
JinhangZhang,
KostasTsiounis,
johnpeck-us-ibm and
taoliult
August 19, 2026 19:04
johnpeck-us-ibm
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BaseTestECDH.test_engineGenerateSecret and
BaseTestXDH.test_engineGenerateSecret were using "DH" for both KeyPairGenerator and KeyAgreement instead of the correct algorithm names "ECDH" and "XDH" respectively. This caused the tests to exercise the wrong key agreement algorithm rather than the one under test.
Fixes: #1721
Signed-off-by: Jason Katonica katonica@us.ibm.com