Improvement/11/activities#11677
Open
chfsx wants to merge 3 commits into
Open
Conversation
Replicates Essential-ILIAS-27/ILIAS-Slim PR ILIAS-eLearning#72 on top of the upstream Activities fixes: pass a FieldFactory to getInputDescription() and an InputFactory to maybePerformAs(). Adapts the ObjectActivity interface accordingly to keep its declaration compatible with Activity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the changes of mjansen (#11551) and Ahmed Hamouda (#10988) and another change we would like to introduce now since there are not many Activities implemented for now.
The topic of Activities will be given greater attention in the coming weeks, and Activities are now being implemented in various projects (e.g. for SCORM or for files (services and objects)). Consequently, minor optimisations are likely to be added on an ongoing basis to ensure that the Activities are as well-suited as possible for all intended purposes.
Furthermore, documents on best practices and how-to guides are also to be produced during this period, so that authorities can begin implementing their own activities as quickly as possible.