News 47877: Improve Timeline Panel Visual Layout#11689
Open
matheuszych wants to merge 3 commits into
Open
Conversation
See: https://mantis.ilias.de/view.php?id=47877 The timeline panel header and footer used float-based spacing and shy buttons with vertical dividers, which produced an uneven layout. Switched the header to flexbox, aligned footer actions with `ilTimelinePanelFooter`, promoted Like and Notes triggers to standard buttons, removed the separators, and updated related language strings and styles.
…s comment button if there are already comments
Contributor
Author
|
The changes unfortunately couldn’t be limited to the news module. We also had to update the Like and Notes components to make this work, so you can expect some related changes in other areas as well. @alex40724 I’d kindly ask you to review these proposed changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://mantis.ilias.de/view.php?id=47877
The timeline panel header and footer used float-based spacing and shy
buttons with vertical dividers, which produced an uneven layout. Switched
the header to flexbox, aligned footer actions with
ilTimelinePanelFooter, promoted Like and Notes triggers to standardbuttons, removed the separators, and updated related language strings and
styles.
/cc @thojou