Skip to content

Guestbook Response DTO Change Username to Name#461

Merged
ekraffmiller merged 1 commit into
developfrom
460-include-name-in-guestbook-responses-api
Jul 8, 2026
Merged

Guestbook Response DTO Change Username to Name#461
ekraffmiller merged 1 commit into
developfrom
460-include-name-in-guestbook-responses-api

Conversation

@ChengShi-1

@ChengShi-1 ChengShi-1 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

"name" was missing in JSON response to get Guestbook Responses
Changed "userName" in guestbook response to "name" to match the parser in API GET /api/guestbooks/{guestbookId}/responses

Which issue(s) this PR closes:

Related Dataverse PRs:

Special notes for your reviewer:

Suggestions on how to test this:

Is there a release notes or changelog update needed for this change?:

Additional documentation:

@ChengShi-1 ChengShi-1 linked an issue Jul 7, 2026 that may be closed by this pull request
@github-actions github-actions Bot added FY26 Sprint 26 FY26 Sprint 26 (2026-06-17 - 2026-07-01) GREI Re-arch GREI re-architecture-related labels Jul 7, 2026
@ChengShi-1 ChengShi-1 added the Size: 0.5 A percentage of a sprint. 0.35 hours label Jul 7, 2026
@ChengShi-1 ChengShi-1 marked this pull request as ready for review July 7, 2026 17:46
Copilot AI review requested due to automatic review settings July 7, 2026 17:46
@ChengShi-1 ChengShi-1 moved this to Ready for Review ⏩ in IQSS Dataverse Project Jul 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the TypeScript GuestbookResponse model and related tests with the Dataverse API change that returns name (instead of userName) in guestbook responses from GET /api/guestbooks/{guestbookId}/responses, addressing the missing field noted in issue #460.

Changes:

  • Renamed GuestbookResponse.userNameGuestbookResponse.name in the domain model.
  • Updated unit test fixtures to use name in mocked guestbook response payloads.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
test/unit/guestbooks/GuestbooksRepository.test.ts Updates mocked guestbook response data to use name instead of userName.
test/unit/guestbooks/GetGuestbookResponsesByGuestbookId.test.ts Updates the GuestbookResponse test fixture to use name.
src/guestbooks/domain/models/GuestbookResponse.ts Renames the response field from userName to name in the public model.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ekraffmiller ekraffmiller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! approved

@github-project-automation github-project-automation Bot moved this from Ready for Review ⏩ to Ready for QA ⏩ in IQSS Dataverse Project Jul 8, 2026
@ekraffmiller

Copy link
Copy Markdown
Contributor

all checks have passed, ok to merge.

@ekraffmiller ekraffmiller merged commit 86e2619 into develop Jul 8, 2026
7 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for QA ⏩ to Merged 🚀 in IQSS Dataverse Project Jul 8, 2026
@pdurbin pdurbin moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 26 FY26 Sprint 26 (2026-06-17 - 2026-07-01) GREI Re-arch GREI re-architecture-related Size: 0.5 A percentage of a sprint. 0.35 hours

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

Include name in guestbook responses api

4 participants