Avoid prop-drilling for collection repository#940
Merged
Conversation
Contributor
|
Removes prop drilling, standardizes repository access, and simplifies tests/stories. Only issue is reduces test coverage slightly to 94.92% which brings it below global threshold |
rtreacy
approved these changes
Apr 6, 2026
Contributor
rtreacy
left a comment
There was a problem hiding this comment.
Uses RepositoryProvider to manage CollectionRepsoitory. Reduces prop-drilling across many components, simplifies component signatures, Improves maintainability. Test coverage over 97%
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR closes:
Special notes for your reviewer:
Error: tsconfig.json(14,25): error TS5107: Option 'moduleResolution=node10' is deprecated and will stop functioning in TypeScript 7.0. Specify compilerOption '"ignoreDeprecations": "6.0"' to silence this error.Official doc of ts: https://www.typescriptlang.org/tsconfig/#moduleResolution
Why bundler exposed that AlertVariant import:
Suggestions on how to test this:
There is no ui change or functional change could be tested
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes or changelog update needed for this change?:
Yes
Additional documentation: