change language for deaccession not valid reason#11985
Conversation
This comment has been minimized.
This comment has been minimized.
stevenwinship
moved this from In Progress 💻
to Ready for Review ⏩
in IQSS Dataverse Project
|
Changes unknown |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
||
| Once the database is updated the Solr indexes need to be rebuilt using the following Admin API: | ||
|
|
||
| - `curl http://localhost:8080/api/admin/index/continue` |
There was a problem hiding this comment.
"continue" only works if you clear the index timestamps first. See https://guides.dataverse.org/en/6.10.1/admin/solr-search-index.html
This is just a heads up. We can probably just suggest a full reindex in the final release notes.
There was a problem hiding this comment.
updated the doc
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
| @@ -0,0 +1,3 @@ | |||
| -- modify datasetversion.deaccessionnote entries with new Bundle string 'file.deaccessionDialog.reason.selectItem.notValid' | |||
| UPDATE dvobject SET indextime=null WHERE id in (SELECT dataset_id FROM datasetversion WHERE deaccessionnote='Not a valid dataset.'); | |||
| UPDATE datasetversion SET deaccessionnote='Not valid. This dataset does not comply with repository policies.' WHERE deaccessionnote='Not a valid dataset.'; | |||
There was a problem hiding this comment.
I'm just putting this at the bottom but why does this PR have 66 commits for such a small change? Seems very strange.
Related:
|
I believe this is working ok, so I'm merging this. The new text looks ok in the dropdown. 
The SQL update seemed to work. Here's the before and after. Before
After
|
github-project-automation
bot
moved this from QA ✅
to Ready for QA ⏩
in IQSS Dataverse Project
github-project-automation
bot
moved this from Ready for QA ⏩
to Merged 🚀
in IQSS Dataverse Project
5 participants
What this PR does / why we need it:The current list of deaccessioning reasons may not fully capture all the legitimate grounds for dataset removal. One common and important case—when a deposit violates repository terms of use, submission policies, or legal/ethical guidelines—is not explicitly listed. Including this as a standardized reason improves clarity and accountability in the deaccessioning process.
Which issue(s) this PR closes:IQSS/dataverse.harvard.edu#360
Special notes for your reviewer:
Suggestions on how to test this: UI and API calls.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: included
Additional documentation: