Skip to content

run tests on windows #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tom-Willemsen merged 8 commits into from
Nov 3, 2025
Merged

run tests on windows #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
33d923c
run tests on windows
rerpha Oct 30, 2025
102fdc4
Activate environment in Lint-and-test workflow
rerpha Oct 30, 2025
95830fc
Merge remote-tracking branch 'origin/main' into rerpha-patch-1
rerpha Oct 30, 2025
ae962ff
might not need activate-environment now
rerpha Oct 30, 2025
6fe2967
Update GitHub Actions to use newer versions
rerpha Oct 30, 2025
9972770
remove env passthrough
rerpha Oct 30, 2025
1e06867
format
rerpha Oct 30, 2025
08284f8
use sys.executable rather than hardcode uv
rerpha Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/Lint-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,14 @@ jobs:
compare-branch: origin/main
python-ver: '3.13'
tests:
runs-on: ubuntu-latest
strategy:
matrix:
version: ['3.10','3.11', '3.12', '3.13', '3.14']
os: ["ubuntu-latest", "windows-latest"]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
- uses: astral-sh/setup-uv@v6
- uses: actions/checkout@v5
- uses: astral-sh/setup-uv@v7
with:
python-version: ${{ matrix.version }}
- name: install requirements
Expand Down
14 changes: 9 additions & 5 deletions system_tests/lewis_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import contextlib
import os
import subprocess
import sys
import time
from pathlib import Path

Expand All @@ -18,8 +19,7 @@
@contextlib.contextmanager
def julabo_simulation():
command = [
"uv",
"run",
sys.executable,
str(LEWIS_PATH),
"julabo",
"-p",
Expand All @@ -34,7 +34,9 @@ def julabo_simulation():


def run_control_command(mode, command, value):
subprocess.check_output(["uv", "run", str(LEWIS_CONTROL_PATH), mode, command, value], env=os.environ).decode()
subprocess.check_output(
[sys.executable, str(LEWIS_CONTROL_PATH), mode, command, value]
).decode()


def santise_whitespace(input_str):
Expand All @@ -43,7 +45,7 @@ def santise_whitespace(input_str):

def query_device_status():
return santise_whitespace(
subprocess.check_output(["uv", "run", str(LEWIS_CONTROL_PATH), "device"], env=os.environ).decode()
subprocess.check_output([sys.executable, str(LEWIS_CONTROL_PATH), "device"]).decode()
)


Expand All @@ -57,7 +59,9 @@ def test_list_available_devices(self):
When: running Lewis without parameters
Then: returns a list of possible simulations
"""
result = santise_whitespace(subprocess.check_output(["uv", "run", str(LEWIS_PATH)]).decode())
result = santise_whitespace(
subprocess.check_output([sys.executable, str(LEWIS_PATH)]).decode()
)

verify(result, self.reporter)

Expand Down