Consume the lazy and symbolic ITensor layer from ITensorBase#124
Merged
Conversation
Remove the local `LazyITensors` submodule and import its types and contraction-order machinery directly from `ITensorBase`, where the implementation now lives. Drop the redundant `TensorOperations` extension and the `AbstractTrees`, `TermInterface`, and `WrappedUnions` dependencies that only the local copy used.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
+ Coverage 74.30% 80.35% +6.04%
==========================================
Files 23 13 -10
Lines 1082 738 -344
==========================================
- Hits 804 593 -211
+ Misses 278 145 -133
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mtfishman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switches ITensorNetworksNext to use the lazy and symbolic ITensor layer from ITensorBase instead of its own copy. The
LazyITensorssubmodule is removed, and its lazy and symbolic types and contraction-order machinery are imported directly from ITensorBase, where the implementation moved in ITensor/ITensorBase.jl#182.Also drops the now-redundant
ITensorNetworksNextTensorOperationsExt(theOptimalorder viaTensorOperations.optimaltreeis provided by ITensorBase's own extension) and theAbstractTrees,TermInterface, andWrappedUnionsdependencies that only the local copy used.