Skip to content

Support PHP 8.5#439

Merged
lippserd merged 5 commits into
mainfrom
support-php-8.4/8.5
Feb 26, 2026
Merged

Support PHP 8.5#439
lippserd merged 5 commits into
mainfrom
support-php-8.4/8.5

Conversation

@Jan-Schuppik
Copy link
Copy Markdown
Contributor

@Jan-Schuppik Jan-Schuppik commented Dec 3, 2025

PHP 8.4 changes:

PHP 8.5 changes:

Other changes:

  • Replace usage of abandoned package clue/block-react with react/async.

resolves #437

@cla-bot cla-bot Bot added the cla/signed CLA is signed by all contributors of a PR label Dec 3, 2025
Comment thread library/Notifications/Daemon/Daemon.php
@sukhwinder33445
Copy link
Copy Markdown
Contributor

Phpstan-baseline is fixed in #403 (0fa137e).

Comment thread library/Notifications/Daemon/Daemon.php Outdated
sukhwinder33445

This comment was marked as spam.

@sukhwinder33445 sukhwinder33445 self-requested a review January 15, 2026 10:44
@lippserd lippserd changed the title Support php 8.4/8.5 Support PHP 8.5 Jan 15, 2026
@lippserd
Copy link
Copy Markdown
Member

@Jan-Schuppik Please rebase.

PHP 8.4 deprecates implicitly nullable parameter declarations, meaning that
declaring a function or method parameter with a default value of `null` without
explicitly marking the type as nullable (using `?Type`) will trigger a
deprecation notice:

https://www.php.net/manual/en/migration84.deprecated.php#migration84.deprecated.core.implicitly-nullable-parameter
`PDO::MYSQL_ATTR_INIT_COMMAND` is deprecated as of PHP 8.5 and should be
replaced with `Pdo\Mysql::ATTR_INIT_COMMAND`:

https://www.php.net/manual/en/migration85.deprecated.php#migration85.deprecated.pdo
`SplObjectStorage` methods `attach()`, `contains()`, and `detach()` are
deprecated in PHP 8.5.

Since these methods are aliases for the methods `offsetSet()`, `offsetExists()`
and `offsetUnset()` of the `ArrayAccess` interface implemented by
`SplObjectStorage`, they can safely be replaced by these equivalents:

https://www.php.net/manual/en/migration85.deprecated.php#migration85.deprecated.spl
In PHP 8.5, `null` can no longer be used as an array key. Previously, `null`
was automatically converted to an empty string (`''`), but this behavior is now
deprecated:

https://www.php.net/manual/en/migration85.deprecated.php#migration85.deprecated.core.using-null-as-an-array-offset
The package has been migrated to `reac/async`. Use that instead.
@lippserd lippserd force-pushed the support-php-8.4/8.5 branch from dc9b261 to c5de5e6 Compare February 26, 2026 12:17
@lippserd lippserd merged commit 8cb6ac1 into main Feb 26, 2026
13 checks passed
@lippserd lippserd deleted the support-php-8.4/8.5 branch February 26, 2026 12:21
@nilmerg nilmerg added this to the 1.0.0 milestone Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla/signed CLA is signed by all contributors of a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PHP 8.4/8.5 Support

5 participants