fix: search_handler yields bytes and handle None in entity_extended_d…#309
Open
TheRealKingS wants to merge 1 commit intoIdentityPython:masterfrom
Open
Conversation
…isplay - search_handler yielded str from dumps() instead of bytes, causing TypeError in gunicorn when streaming search results - entity_extended_display could return None for display/info causing AttributeError on .strip() when searching for SPs Tested on pyFF 2.1.5 with gunicorn 25.1.0 and Python 3.12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: search_handler yields bytes and handle None in entity_extended_display
Tested on pyFF 2.1.5 with gunicorn 25.1.0 and Python 3.12
All Submissions: