Skip to content

fix: search_handler yields bytes and handle None in entity_extended_d…#309

Open
TheRealKingS wants to merge 1 commit intoIdentityPython:masterfrom
TheRealKingS:fix/search-handler-bytes-and-none-strip
Open

fix: search_handler yields bytes and handle None in entity_extended_d…#309
TheRealKingS wants to merge 1 commit intoIdentityPython:masterfrom
TheRealKingS:fix/search-handler-bytes-and-none-strip

Conversation

@TheRealKingS
Copy link

fix: search_handler yields bytes and handle None in entity_extended_display

  • search_handler yielded str from dumps() instead of bytes, causing TypeError in gunicorn when streaming search results
  • entity_extended_display could return None for display/info causing AttributeError on .strip() when searching for SPs

Tested on pyFF 2.1.5 with gunicorn 25.1.0 and Python 3.12

All Submissions:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what problem you are trying to solve with this PR?
  • Have you added information on what your changes do and why you chose this as your solution?
  • [] Have you written new tests for your changes?
  • Does your submission pass tests?
  • This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

…isplay

- search_handler yielded str from dumps() instead of bytes,
  causing TypeError in gunicorn when streaming search results
- entity_extended_display could return None for display/info
  causing AttributeError on .strip() when searching for SPs

Tested on pyFF 2.1.5 with gunicorn 25.1.0 and Python 3.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant