Skip to content

fix(react): update the query builder snippets#403

Open
Hristo313 wants to merge 6 commits into
vnextfrom
hhristov/fix-query-builder-react-snippets
Open

fix(react): update the query builder snippets#403
Hristo313 wants to merge 6 commits into
vnextfrom
hhristov/fix-query-builder-react-snippets

Conversation

@Hristo313

Copy link
Copy Markdown
Contributor

Closes #240

Checklist:

  • check topic's TOC/menu and paragraph headings
  • Include TOC topic labels in the topic content when it has a valuable update, is new, or is considered preview / beta
  • link to other topics using ../relative/path.md
  • at the References section at the end of the topic add links to topics, samples, etc
  • reference API documentation instead of adding a section with API

  • use valid component names - [Data] Grid, IgxSelectComponent, <igx-combo>
  • use spell checker tool (VS Code, Grammarly, Microsoft Editor)
  • add inline code blocks for the names of classes / tags / properties
  • add language descriptor for the code blocks
  • check if links function by running the check-api/mdx npm commands
  • check if sample is working and fully visible in the topic
  • check if sample is working and fully visible in the StackBlitz
  • check if code blocks match the code in StackBlitz demo
  • add or update meaningful llms.description metadata and run npm run check:llms-metadata


  • do not resolve requested changes (leave that to the reviewer)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the React Query Builder documentation snippets to use functional components and React hooks instead of deprecated class component patterns, aligning the docs with current React best practices (per #240).

Changes:

  • Replaced class lifecycle patterns (constructor, componentDidMount, componentWillUnmount) with useRef/useState/useEffect in React snippets.
  • Updated template-related React snippets to remove this.* usage in favor of function-scope callbacks.
  • Adjusted code block language identifiers to better match the shown JSX/TSX snippets.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/xplat/src/content/en/components/inputs/query-builder.mdx Outdated
Comment thread docs/xplat/src/content/en/components/inputs/query-builder.mdx
Comment thread docs/xplat/src/content/en/components/inputs/query-builder.mdx
Comment thread docs/xplat/src/content/en/components/inputs/query-builder.mdx
Comment thread docs/xplat/src/content/en/components/inputs/query-builder.mdx
Comment thread docs/xplat/src/content/en/components/inputs/query-builder.mdx
@IgniteUI IgniteUI deleted a comment from Copilot AI Jul 7, 2026
@Hristo313 Hristo313 requested a review from IMinchev64 July 7, 2026 11:52
@Hristo313 Hristo313 changed the title fix(react): query builder snippets fix(react): update the query builder snippets Jul 7, 2026
@IMinchev64 IMinchev64 added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💥 status: in-test PRs currently being tested platform: react

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[React] Query builder snippets are using React class components which are deprecated

4 participants