ci(dependabot): ignore major-version bumps of mcp - #38
Merged
Conversation
The `mcp>=1.28.1,<2` cap does not keep SDK 2.0 out on its own. Dependabot maintains the constraint rather than obeying it: the very next run proposed `mcp>=2.0.0,<3`, and CI failed again on `ModuleNotFoundError: No module named 'mcp.server.fastmcp'`. An ignore condition is the only thing that holds the line. It is evaluated before grouping, so the weekly `python` group still ships every other bump — it just stops carrying mcp 2.x. Drop this entry when the SDK 2.0 migration lands; the pyproject comment points here so the two can't drift apart. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR prevents Dependabot from proposing MCP SDK major upgrades that break the current MCP adapter (which still targets the 1.x mcp.server.fastmcp API). It does so by adding a Dependabot ignore rule for mcp semver-major updates, while keeping the existing <2 constraint in pyproject.toml, and cross-referencing the two so they’re updated together.
Changes:
- Add a Dependabot ignore rule to skip
mcpmajor-version bumps in the weeklyuvdependency group. - Clarify in
pyproject.tomlthat the<2cap is enforced operationally by Dependabot ignore rules (not just by resolution constraints).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Adds a comment explaining the cap/Dependabot interaction and linking to the ignore rule. |
| .github/dependabot.yml | Adds an ignore entry to prevent mcp semver-major updates from being proposed. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
mcp<2cap merged in #35 did not hold. Dependabot closed #33 and immediately opened #37,which rewrites the constraint instead of respecting it:
So #37 fails exactly the way #33 did:
This is dependabot behaving as designed — it treats a version constraint as something it
maintains, not a boundary it stays inside. A cap in
pyproject.tomlprotects resolution(nobody accidentally installs 2.x); it does not stop dependabot from proposing to raise the cap.
The ruff half of the original diagnosis did hold: lint and format both pass on #37 under
ruff 0.16.0, thanks to #34.
What
An
ignorecondition for major bumps ofmcp. Ignore conditions are evaluated beforegrouping, so the weekly
pythongroup keeps shipping every other update — it just stopscarrying mcp 2.x.
Also adds a line to the
pyproject.tomlcomment pointing at the ignore rule, so a readerdoesn't assume the cap is self-enforcing, and so the two get changed together.
Lifetime
This is a hold, not a decision. Drop the entry when the SDK 2.0 port (#36, currently draft)
lands — both the commit message and the pyproject comment say so.
After this merges
#37 needs
@dependabot recreate(notrebase— the group has to be regenerated for the newignore rule to apply). It should come back with duckdb, fastapi and ruff only, and go green.
🤖 Generated with Claude Code