Trim SKILL.md from 791 to 684 lines (1.7.1) - #32
Open
fedorov wants to merge 1 commit into
Open
Conversation
SKILL.md grew to 791 lines in 1.7.0 with the MCP section, reversing the reduction trend since v1.5.0 (862 -> 773 -> 750). The guidance the repo has been tracking is under 500 lines, with a Phase 2 target of ~600. Nearly all of this is relocation, not deletion: - The three "what's new in IDC vX" queries move to a new Version Tracking section in sql_patterns.md. SKILL.md keeps the guidance that prevents mistakes: use series_init_idc_version / series_revised_idc_version, never prior_versions_index. - The repeated `from idc_index import IDCClient` / `client = IDCClient()` preamble is dropped from six examples and stated once in the Overview, matching how sql_patterns.md is already written. - The second filter-value-discovery query duplicated the BodyPartExamined idiom already in sql_patterns.md; the flat-dirTemplate and source_bucket_location="gcs" download variants are now prose beside the canonical example. - The DICOMweb endpoint table, citations_from_selection parameter list, and downloaded-file-naming bullets are condensed to prose; full endpoint details remain in dicomweb_guide.md. The cloud storage bucket table is deliberately kept: it carries the CC BY-NC distinction the license workflow depends on, and compressing it to prose dropped the head-scans bucket. ~600 is not reachable without deleting content rather than relocating it. What remains in the largest sections is anti-footgun guidance (the two download-method signatures, "not a DataFrame") and decision tables. Test docstrings now name their SKILL.md section instead of numbering it; "§6 Batch Processing" was stale, since batch processing moved to use_cases.md in v1.6.0 and section 6 is now BigQuery. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SKILL.mdgrew to 791 lines in 1.7.0 with the MCP section, reversing the reduction trend since v1.5.0 (862 → 773 → 750). The guidancerefactor.mdhas been tracking is under 500 lines, with a Phase 2 target of ~600.791 → 684 lines (−13.5%), 15 code blocks.
Nearly all relocation, not deletion
references/sql_patterns.md.SKILL.mdkeeps the part that prevents mistakes — useseries_init_idc_version/series_revised_idc_version, neverprior_versions_index— as a pointer.from idc_index import IDCClient/client = IDCClient()preamble is dropped from six examples and stated once in the Overview. This matches howsql_patterns.mdis already written.BodyPartExaminedidiom already atsql_patterns.md:38-43. The flat-dirTemplateandsource_bucket_location="gcs"download variants are now prose beside the canonical example.citations_from_selectionparameter list, and the downloaded-file-naming bullets are condensed to prose; the full endpoint details remain inreferences/dicomweb_guide.md.references/bigquery_guide.mdpointers in "Advanced Queries with BigQuery".Deliberately kept
The cloud storage bucket table stays inline.
cloud_storage_guide.md:23-25does carry it verbatim, so compressing it wouldn't lose anything from the skill as a whole — but the table carries the CC BY-NC distinction that the license workflow depends on, and the compressed wording dropped theidc-open-data-twohead-scans bucket entirely.~600 is not reachable without deleting content rather than relocating it. What remains in the largest sections is anti-footgun guidance (the two download-method signatures, the "takes filter kwargs, NOT a DataFrame" warning) and decision tables, not redundant examples.
refactor.mdrecords this rather than leaving the target looking silently missed.Test docstrings
Five test docstrings referenced SKILL.md sections by number (
§1,§2, …), which is opaque without the file open. They now name the section. One was stale:"§6 Batch Processing"— section 6 has been Advanced Queries with BigQuery since batch processing moved touse_cases.mdin v1.6.0.Testing
Run against idc-index 0.12.5 / idc-index-data 24.2.2 / pandas 3.0.5:
tests/test_snippets.pytests/test_mcp_server.pyThe version guard (
SKILL.mdfrontmatter ↔check_version.py) passes at 1.7.1.🤖 Generated with Claude Code