BUG: Replace hard-coded itkeigen/ path in itkSpecialFunctions.h#6527
Merged
dzenanz merged 1 commit intoJun 27, 2026
Merged
Conversation
itkSpecialFunctions.h used a hard-coded 'itkeigen/unsupported/Eigen/SpecialFunctions' include that fails when ITK_USE_SYSTEM_EIGEN=ON. Switch to the ITK_EIGEN_UNSUPPORTED(SpecialFunctions) macro, consistent with the fix applied to itkMatrixExponential.h and itkEigenLevenbergMarquardtEngine.cxx in the prior commit.
Contributor
|
| Filename | Overview |
|---|---|
| Modules/Core/Common/include/itkSpecialFunctions.h | Switches the SpecialFunctions include to the configured Eigen include macro used for system and vendored Eigen builds. |
Reviews (1): Last reviewed commit: "BUG: Replace hard-coded itkeigen/ path w..." | Re-trigger Greptile
Member
Author
|
@greptile-apps Please remember include of Eigen headers need an ITK_EIGEN macro and direct include of eigen headers in ITK should not occur. |
Contributor
|
Got it — I've created a rule to enforce this going forward. Rule: All Eigen header includes in ITK must use the |
dzenanz
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the remaining hard-coded
itkeigen/unsupported/Eigen/SpecialFunctionsinclude initkSpecialFunctions.hthat breaks compilation whenITK_USE_SYSTEM_EIGEN=ON.Replaces the path with
ITK_EIGEN_UNSUPPORTED(SpecialFunctions)and adds the required#include "itk_eigen.h", consistent with the fix in commit 8543e2f that addressed the same pattern initkMatrixExponential.h,itkEigenLevenbergMarquardtEngine.cxx, andvnl_levenberg_marquardt.cxx.AI assistance
#include "itkeigen/patterns after reviewing the referenced commit.