Skip to content

fix(lint): ignore secrets/ in eslint#149

Merged
InstaZDLL merged 1 commit into
mainfrom
fix/eslint-ignore-secrets
May 25, 2026
Merged

fix(lint): ignore secrets/ in eslint#149
InstaZDLL merged 1 commit into
mainfrom
fix/eslint-ignore-secrets

Conversation

@InstaZDLL
Copy link
Copy Markdown
Owner

@InstaZDLL InstaZDLL commented May 25, 2026

Summary

secrets/ is gitignored (release keys + the OpenRouter validate-translations.mjs helper live there) but eslint was still scanning it, producing 14 no-undef errors on Node globals (console, fetch, setTimeout) every time bun run lint was run on a checkout where the script is present. Adding secrets/** to the ignore list mirrors how scripts/ is already excluded.

Test plan

  • bun run lint exits cleanly on a checkout that contains secrets/validate-translations.mjs.
  • bun run lint still flags real issues in src/**.

Summary by CodeRabbit

Notes de version

  • Chores
    • Mise à jour de la configuration ESLint pour ignorer les fichiers de secrets lors du linting du code.

Review Change Stack

The secrets/ directory is gitignored (only local copies of release
keys + the OpenRouter validate-translations script live there), but
eslint was still scanning it because the path wasn't in the eslint
config's ignore list. That surfaced as 14 no-undef errors on standard
Node globals (console, fetch, setTimeout) every time `bun run lint`
was run on a checkout with the script present.

Mirrors how scripts/ is already excluded.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 25, 2026

📝 Walkthrough

Walkthrough

La configuration ESLint est modifiée pour ajouter secrets/** aux motifs ignorés. Cette exclusion empêche l'analyse de fichiers sensibles dans le répertoire secrets et n'altère pas le reste de la configuration (recommandations, règles TypeScript, React Hooks, React Refresh).

Changes

Exclusion ESLint des répertoires sensibles

Couche / Fichier(s) Résumé
Exclusion du répertoire secrets
eslint.config.js
Le motif secrets/** est ajouté à la liste ignores pour exclure les fichiers sensibles de l'analyse ESLint.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🔐 Des secrets bien gardés,
Loin du lint et des regards,
Dans l'ombre, protégés ! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed Le titre décrit précisément le changement principal : ajouter secrets/ à la liste d'exclusion d'ESLint.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed La description PR respecte le template requis avec un résumé clair du problème et un plan de test concret et vérifiable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/eslint-ignore-secrets

Comment @coderabbitai help to get the list of available commands and usage tips.

@InstaZDLL InstaZDLL added scope: frontend React/Vite frontend (src/) type: fix Bug fix size: xs < 10 lines labels May 25, 2026
@InstaZDLL InstaZDLL self-assigned this May 25, 2026
@InstaZDLL InstaZDLL merged commit 3275940 into main May 25, 2026
13 checks passed
@InstaZDLL InstaZDLL deleted the fix/eslint-ignore-secrets branch May 25, 2026 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: frontend React/Vite frontend (src/) size: xs < 10 lines type: fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant