fix(lint): ignore secrets/ in eslint#149
Merged
Merged
Conversation
The secrets/ directory is gitignored (only local copies of release keys + the OpenRouter validate-translations script live there), but eslint was still scanning it because the path wasn't in the eslint config's ignore list. That surfaced as 14 no-undef errors on standard Node globals (console, fetch, setTimeout) every time `bun run lint` was run on a checkout with the script present. Mirrors how scripts/ is already excluded.
📝 WalkthroughWalkthroughLa configuration ESLint est modifiée pour ajouter ChangesExclusion ESLint des répertoires sensibles
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
secrets/is gitignored (release keys + the OpenRoutervalidate-translations.mjshelper live there) but eslint was still scanning it, producing 14no-undeferrors on Node globals (console,fetch,setTimeout) every timebun run lintwas run on a checkout where the script is present. Addingsecrets/**to the ignore list mirrors howscripts/is already excluded.Test plan
bun run lintexits cleanly on a checkout that containssecrets/validate-translations.mjs.bun run lintstill flags real issues insrc/**.Summary by CodeRabbit
Notes de version