Extend `_tensor_elementwise_impl` with binary functions part 2 by vlad-perevezentsev · Pull Request #2804 · IntelPython/dpnp

vlad-perevezentsev · 2026-03-05T13:56:54Z

This PR extends _tensor_elementwise_impl with part of binary functions :

divide,
equal,
floor_divide,
greater,
greater_equal,
hypot,
less,
less_equal,
logaddexp

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
Have you added documentation for your changes, if necessary?
Have you added your changes to the changelog?

…part_2

…_impl_unary_par_2

…ntwise_impl_unary_par_3

…part_2

ndgrigorian

I looked over includes and nothing stood out, this one LGTM

was put in wrong PR

antonwolfy · 2026-03-18T15:35:44Z

dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/equal.hpp

+                                        std::complex<float>,
+                                        T2,
+                                        std::complex<float>,
+                                        bool>,
+        td_ns::BinaryTypeMapResultEntry<T1,
+                                        std::complex<double>,
+                                        T2,
+                                        std::complex<double>,
+                                        bool>,


The following kernel header files use std::complex and std::complex in their type mappings but are missing the <complex> include:

dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/equal.hpp
dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/greater.hpp
dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/greater_equal.hpp
dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/less.hpp
dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/less_equal.hpp
dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/true_divide.hpp

antonwolfy · 2026-03-18T15:36:29Z

dpctl_ext/tensor/libtensor/source/elementwise_functions/true_divide.cpp

+/// extension, specifically functions for elementwise operations.
+//===---------------------------------------------------------------------===//
+
+#include <complex>


Missing <algorithm> for std::copy (used at line 405)
Missing <string> for std::to_string (used at line 360)

antonwolfy · 2026-03-18T15:48:07Z

dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/equal.hpp

+#include "kernels/dpctl_tensor_types.hpp"
+#include "kernels/elementwise_functions/common.hpp"
+
+#include "utils/offset_utils.hpp"


All 8 kernel header files include utils/offset_utils.hpp but never use it directly:

equal.hpp
floor_divide.hpp
greater.hpp
greater_equal.hpp
hypot.hpp
less.hpp
less_equal.hpp
true_divide.hpp

antonwolfy · 2026-03-18T15:58:48Z

dpctl_ext/tensor/libtensor/source/elementwise_functions/elementwise_common.cpp

-    // init_logical_and(m);
+    init_logaddexp(m);
    init_logical_not(m);
-    // init_logical_or(m);


Was it removed by mistake or intentionally?

github-actions · 2026-03-18T16:17:33Z

Array API standard conformance tests for dpnp=0.20.0dev3=py313h509198e_227 ran successfully.
Passed: 1355
Failed: 2
Skipped: 16

vlad-perevezentsev added 30 commits February 3, 2026 12:16

Rename folder dpctl to dpctl_ext

d4fd805

Add simplify_iteration_space implementation to libtensor

c040713

Extend codespell ignore list for libtensor

14b466f

Add copy_and_cast kernels to libtensor

dcc421b

Add copy_usm_ndarray_into_usm_ndarray implementation

5a9c14c

Add pybind11 bindings for dpctl_ext.tensor._tensor_impl

4f63340

Add CMake build files for dpctl_ext

634579c

Add empty __init__ to dpctl_ext/

79d40f2

Enable _same_logical_tensors in _tensor_impl

7949c17

Add device_support_queries to enable default device types

29d6c02

Enable building and packaging of dpctl_ext

936e719

Use _tensor_impl from dpctl_ext.tensor in dpnp

cd85f1e

Move put() and take() to dpctl_ext/tensor

0c6780a

Use put/take from dpctl_ext.tensor in dpnp

87e5482

Move full() to dpctl_ext/tensor

b537f30

Use full and _full_usm_ndarray from dpctl_ext in dpnp

d50f263

Update .gitignore to ignore .so files in dpctl_ext

f189dc5

Move _zeros_usm_ndarray to dpctl_ext

f9a1817

Use _zeros_usm_ndarray from dpctl_ext in dpnp_fill.py

4b8505a

Move linear-sequence implementations to dpctl_ext/tensor

61106b2

Use _tensor_impl from dpctl_ext in dpnp_utils_fft.py

a030579

Move tril()/triu() to dpctl_ext/tensor

a1d6fa3

Use tril/triu/_tril from dpctl_ext.tensor in dpnp

f1d6e56

Disable pylint no-name-in-module for dpctl_ext

6680790

Add TODO comments

263b717

Use default_device_complex_type from dpctl_ext on test_array_api_info.py

4130c1b

Remove unused build_dpctl_ext function

17ca9ab

Apply remarks for CMake files

79cb2a4

Apply remarks for c++ files

4bf080e

Remove linear-sequence implementations

cfa6cd6

vlad-perevezentsev and others added 17 commits March 5, 2026 13:02

Add missing logaddexp to __init__.py

ee6ba17

Merge move_elementwise_binary_impl into move_elementwise_binary_impl_…

d80285e

…part_2

fix includes and namespaces in dot.cpp

3bd1b0e

use dpctl_ext.tensor throughout _linear_algebra_functions

1620f77

fix clang-format

75580a5

abbreviate namespaces in linalg module sources and headers

7e6a283

Merge include-dpctl-tensor into move_tensor_elementwise_impl_unary

5d11ff7

Apply remarks

281adbf

Merge move_tensor_elementwise_impl_unary into move_tensor_elementwise…

7b63ab5

…_impl_unary_par_2

Clean-up includes

a2d28af

Merge move_tensor_elementwise_impl_unary_par_2 into move_tensor_eleme…

1403be4

…ntwise_impl_unary_par_3

Clean-up includes

0182c74

Merge move_tensor_elementwise_impl_unary_par_3 into move-tensor-linalg

86878cf

Add the missing includes for dot.cpp

c0ff29f

Merge move-tensor-linalg into move_elementwise_binary_impl

ca295f1

Clean-up includes

e6e179e

Merge move_elementwise_binary_impl into move_elementwise_binary_impl_…

ed289fc

…part_2

vlad-perevezentsev marked this pull request as ready for review March 11, 2026 15:56

vlad-perevezentsev requested review from antonwolfy and ndgrigorian as code owners March 11, 2026 15:56

Clean-up includes

608802a

vlad-perevezentsev force-pushed the move_elementwise_binary_impl_part_2 branch from a3b2d00 to 608802a Compare March 11, 2026 18:53

ndgrigorian previously approved these changes Mar 12, 2026

View reviewed changes

ndgrigorian self-requested a review March 12, 2026 01:11

Base automatically changed from move_elementwise_binary_impl to include-dpctl-tensor March 18, 2026 14:23

vlad-perevezentsev added 2 commits March 18, 2026 07:41

Merge include-dpctl-tensor into move_elementwise_binary_impl_part_2

fddedde

Add a missing include

969ec9a

antonwolfy reviewed Mar 18, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extend `_tensor_elementwise_impl` with binary functions part 2#2804

Extend `_tensor_elementwise_impl` with binary functions part 2#2804
vlad-perevezentsev wants to merge 204 commits intoinclude-dpctl-tensorfrom
move_elementwise_binary_impl_part_2

vlad-perevezentsev commented Mar 5, 2026 •

edited

Loading

Uh oh!

ndgrigorian left a comment

Uh oh!

antonwolfy Mar 18, 2026

Uh oh!

antonwolfy Mar 18, 2026

Uh oh!

antonwolfy Mar 18, 2026

Uh oh!

antonwolfy Mar 18, 2026

Uh oh!

github-actions bot commented Mar 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

vlad-perevezentsev commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ndgrigorian left a comment

Choose a reason for hiding this comment

Uh oh!

antonwolfy Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

antonwolfy Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

antonwolfy Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

antonwolfy Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vlad-perevezentsev commented Mar 5, 2026 •

edited

Loading