Fix diagonal() strides calculation for empty results#2814
Merged
antonwolfy merged 6 commits intomasterfrom Mar 19, 2026
Merged
Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.20.0dev4=py313h509198e_16 ran successfully. |
Collaborator
vlad-perevezentsev
approved these changes
Mar 13, 2026
Contributor
vlad-perevezentsev
left a comment
There was a problem hiding this comment.
LGTM
Thank you @antonwolfy !
github-actions bot
added a commit
that referenced
this pull request
Mar 19, 2026
Previously `dpnp.diagonal()` returned incorrect strides when the diagonal was empty (e.g., when offset >= array width). The stride was set to itemsize instead of the correct `st_n + st_m`. This PR: * fixes stride calculation to consistently use (st_n + st_m) * simplifies implementation using unified formula to calculate resulting shape, strides, and offset * extends tests coverage including scenarios with empty diagonals, views, and non-contiguous arrays The PR closes #2761. db486b9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
dpnp.diagonal()returned incorrect strides when the diagonal was empty (e.g., when offset >= array width). The stride was set to itemsize instead of the correctst_n + st_m.This PR:
The PR closes #2761.