[MAINT] Change clang-format for pre-commit#289
Merged
ndgrigorian merged 7 commits intomasterfrom Mar 19, 2026
Merged
Conversation
also adds .clang-format and moves to clang-format-22
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s C/C++ formatting tooling by switching the pre-commit clang-format hook to pre-commit/mirrors-clang-format, introducing a project .clang-format configuration, and reformatting existing headers accordingly.
Changes:
- Switch pre-commit clang-format hook source and upgrade to clang-format 22.
- Add a repository-wide
.clang-formatfile and reformat affected headers. - Record the formatting commit in
.git-blame-ignore-revs.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
mkl_fft/src/multi_iter.h |
clang-format reflow; touched iterator implementation code. |
mkl_fft/src/mklfft.h |
clang-format reflow of public C API declarations. |
.pre-commit-config.yaml |
Switch clang-format hook to mirrors-clang-format and bump version. |
.git-blame-ignore-revs |
Add ignore entry for the reformatting commit. |
.clang-format |
New formatting configuration used by clang-format/pre-commit. |
You can also share your feedback on Copilot code review. Take the survey.
5b14095 to
e6c3401
Compare
antonwolfy
reviewed
Mar 19, 2026
mkl_fft does not use C++ so it isn't needed
antonwolfy
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes