Use RuntimeWarning when unpatching more than patching#295
Merged
ndgrigorian merged 3 commits intomasterfrom Mar 19, 2026
Merged
Use RuntimeWarning when unpatching more than patching#295ndgrigorian merged 3 commits intomasterfrom
RuntimeWarning when unpatching more than patching#295ndgrigorian merged 3 commits intomasterfrom
Conversation
ndgrigorian
requested review from
antonwolfy,
jharlow-intel and
xaleryb
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the NumPy patch/unpatch helper to emit a RuntimeWarning when restore_numpy_fft() is called more times than patch_numpy_fft() within a thread, replacing the prior verbose-only print message.
Changes:
- Import
warningsand replace the verbose-only print withwarnings.warn(..., RuntimeWarning, stacklevel=2)in_GlobalPatch.do_restore().
You can also share your feedback on Copilot code review. Take the survey.
antonwolfy
reviewed
Mar 19, 2026
antonwolfy
approved these changes
Mar 19, 2026
Collaborator
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
Thank you @ndgrigorian, the only last nit is to populate the changelog, if you don't mind.
Collaborator
Author
|
@antonwolfy |
antonwolfy
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the printed message (only in verbose mode) for unpatching more than patching in a thread to a warning, which seems more appropriate