Skip to content

chore: meta.yaml to accommodate numpy-base or numpy#105

Merged
jharlow-intel merged 6 commits intomasterfrom
task/numpy_base_toggle
Mar 26, 2026
Merged

chore: meta.yaml to accommodate numpy-base or numpy#105
jharlow-intel merged 6 commits intomasterfrom
task/numpy_base_toggle

Conversation

@jharlow-intel
Copy link
Collaborator

adds USE_NUMPY_BASE toggle that defaults to true for internal meta.yaml

Plan is the recipe can support either or in the near-future.

Tried to be helpful and bump the version number, too

@ndgrigorian
Copy link
Collaborator

@jharlow-intel
It is still not clear to me, why do we need to keep numpy-base dependency?

For a fallback, it's clear what purpose it might serve, but I'm not sure I follow the issue with the wheels.

@jharlow-intel
Copy link
Collaborator Author

jharlow-intel commented Mar 20, 2026

@jharlow-intel It is still not clear to me, why do we need to keep numpy-base dependency?

For a fallback, it's clear what purpose it might serve, but I'm not sure I follow the issue with the wheels.

For wheels, the ecosystem itself does not support non-root system packages(this is a big reason why conda was created in the first place, to make isolated environments that don't pollute system paths), so we pretty much have to continue ensuring we use Intel numpy for wheels in the meantime until we make some kind of workaround for that.

Maybe I'm misunderstanding what we can here, though

@jharlow-intel jharlow-intel marked this pull request as draft March 20, 2026 14:35
@jharlow-intel
Copy link
Collaborator Author

Debugging this so converting to draft

@jharlow-intel jharlow-intel force-pushed the task/numpy_base_toggle branch from 2f7a739 to d18d276 Compare March 20, 2026 17:06
@jharlow-intel jharlow-intel marked this pull request as ready for review March 20, 2026 17:08
@jharlow-intel
Copy link
Collaborator Author

wheels builds are going to act a little funny because the jenkins CI logic isn't merged yet, but new CI logic was tested manually, this PR works.

@antonwolfy antonwolfy added this to the 1.4.0 release milestone Mar 23, 2026
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jharlow-intel, LGTM!

@jharlow-intel jharlow-intel merged commit e508685 into master Mar 26, 2026
97 of 103 checks passed
@jharlow-intel jharlow-intel deleted the task/numpy_base_toggle branch March 26, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants