Fix for overlapping text in some books#2792
Open
Vwing wants to merge 1 commit into
Open
Conversation
Collaborator
|
Does this only happen with SDF fonts? What aspect ratio have you tested? I figured it's worth having if it fixes one case, I'm just curious if you've tested the other scenarios (no SDF font, faked aspect ratios), both before and after. |
Author
|
Different aspect ratios don't seem to change anything; the books end up always drawing at the same size, drawing off the screen if the screen is too skinny. The bug only affects SDF fonts 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2619 introduced an issue with books sometimes having overlapping text.
Example: The Real Barenziah, Part V
The fix was a single line. Just needed to set the TextLabel's parent to the pagePanel before calculating its size.
After the fix:
