refactor(issues): migrate repeated certificates issue to ledger repo#3389
Merged
refactor(issues): migrate repeated certificates issue to ledger repo#3389
Conversation
…and update handling - Change the `api_484` blocker to `ledger_4566` blocker for the same issue in `cardano-ledger` - Update test logic in `test_addr_registration.py` to reference `ledger_4566` instead of `api_484` - Enhance `GH.finish_test()` to support forced xfail via `force_blocked` parameter for cases where the issue will not be fixed in certain node version, but rather in next era.
mkoura
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the test suite’s blocker tracking for the “repeated certificates stripped from Conway transaction” issue by moving it from the cardano-api repo issue to the corresponding cardano-ledger repo issue, and adds a mechanism to force an XFAIL in eras where the issue is known to remain unfixed.
Changes:
- Replace
issues.api_484withissues.ledger_4566and update affected test logic accordingly. - Add
force_blockedsupport toblockers.GH.finish_test()to force an XFAIL outcome. - Adjust
test_addr_registration_certificate_orderto force XFAIL in Conway but use normal blocker evaluation in later eras.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
cardano_node_tests/utils/blockers.py |
Extends GH.finish_test() with force_blocked to support forced XFAIL behavior. |
cardano_node_tests/tests/test_addr_registration.py |
Switches the test’s blocker reference to ledger_4566 and forces XFAIL specifically for Conway. |
cardano_node_tests/tests/issues.py |
Removes api_484 and introduces ledger_4566 pointing to IntersectMBO/cardano-ledger#4566. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
api_484blocker toledger_4566blocker for the same issue incardano-ledgertest_addr_registration.pyto referenceledger_4566instead ofapi_484GH.finish_test()to support forced xfail viaforce_blockedparameter for cases where the issue will not be fixed in certain node version, but rather in next era.