Open
Conversation
Jimbo4350
force-pushed
the
fix/flaky-multiasset-collateral-test
branch
from
c7cc8d9 to
bf80309
Compare
carbolymer
reviewed
Mar 31, 2026
| -- Find the UTxO with tokens at wallet1 (for collateral) | ||
| txinCollateralWithTokensM <- | ||
| -- Find the UTxO with tokens at wallet2 (for collateral) | ||
| (txinCollateralWithTokens, collateralTxOut) <- retryUntilJustM epochStateView (WaitForBlocks 10) $ |
Contributor
There was a problem hiding this comment.
The mint transaction may not be confirmed within a single block, causing findLargestMultiAssetUtxoWithAddress to return Nothing and the test to fail spuriously
When this happens? Why it may not get confirmed within a single block?
Contributor
Author
There was a problem hiding this comment.
Hard to say exactly, but maybe a block gets forged before the tx has time to enter the mempool. We then wait for that block and query the node state, but it still reflects the pre-tx state. The tx only gets included in the next block, which updates the node state but by then the test has already failed.
carbolymer
reviewed
Mar 31, 2026
Contributor
There was a problem hiding this comment.
This test should use integrationRetryWorkspace instead of integrationWorkspace
Jimbo4350
force-pushed
the
fix/flaky-multiasset-collateral-test
branch
from
d36573e to
014595c
Compare
carbolymer
approved these changes
Mar 31, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
retryUntilJustMpolling (up to 10 blocks) for the multi-asset UTxO inhprop_collateral_with_tokensfindLargestMultiAssetUtxoWithAddressto returnNothingand the test to fail spuriouslyTest plan
Collateral With Multiassetstest on aarch64-linux (previously failing: check run 69208753482)🤖 Generated with Claude Code