You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
An operator who sets S3PROXY_S3_OPERATION_TIMEOUT=3600 (a plausible guess for "one hour") gets 120 seconds, with nothing in the logs saying so. They will most likely discover it from timeouts in production rather than from the config. The same applies to a typo that fails to parse as an int64 — koanf yields 0, which also lands on the default.
Either a log.Warn at startup or a hard failure in Validate() would make the misconfiguration visible. Given that the other bounded knobs in this file (MaxPutBodySize, MultipartMaxSize) follow the same silent-clamp pattern, a single consistent treatment across all of them would probably be the cleaner fix.
Also a heads-up for anyone rebasing onto main: this PR removed the s3OperationTimeout constant from object.go, and #52 adds a new use of it in handler_multipart.go. Git merges both without reporting a conflict, but the result does not compile — see the note on #52.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.