Skip to content

Update UpdateDescriptions method to accumulate failure descriptions a… #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterbarancek merged 4 commits into from
Jun 5, 2026
Merged

Update UpdateDescriptions method to accumulate failure descriptions a… #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
71b28bd
Update UpdateDescriptions method to accumulate failure descriptions a…
peterbarancek Jun 4, 2026
258a980
Merge branch 'dev' into 54-_BUG_UpdateComprehensiveResult_overwrites_…
peterbarancek Jun 4, 2026
83dd966
*fixed inspector due pagefault
peterbarancek Jun 4, 2026
4a6a081
Merge branch '54-_BUG_UpdateComprehensiveResult_overwrites_failure_de…
peterbarancek Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/TcoInspectors/src/XAE/XAE/TcoInspectors/POUs/TcoInspectionGroup/TcoInspectionGroup.TcPOU
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,6 +562,9 @@ END_IF;
</docu>
~*)
METHOD PROTECTED UpdateDescriptions
VAR_INPUT
inOriginalResult:TcoComprehensiveResult;;
END_VAR
Comment on lines +565 to +567
VAR_IN_OUT
inoResult : TcoComprehensiveResult;
END_VAR
Expand All @@ -572,13 +575,13 @@ END_VAR
END_IF
IF(_done AND NOT _done_PV) THEN
inoResult.Failures := THIS^.Context.Environment.Messaging.StringBuilder.Clear()
.Append(inoResult.Failures)
.Append(inOriginalResult.Failures)
.Append(CommonData.FailureDescription)
.Append(';')
.ToString();

inoResult.ErrorCodes := THIS^.Context.Environment.Messaging.StringBuilder.Clear()
.Append(inoResult.ErrorCodes)
.Append(inOriginalResult.ErrorCodes)
.Append(CommonData.ErrorCode)
.Append(';')
.ToString();
Expand Down
4 changes: 1 addition & 3 deletions src/TcoInspectors/src/XAE/XAE/TcoInspectors/POUs/TcoInspector/TcoInspector.TcPOU
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,9 +637,7 @@ _refOverallResult REF= inoResult;
IF (_tierUpdateOverall.IsNewTier()) THEN
_originalOverallResult := inoResult;
END_IF
IF _coordinator.IsFreshState THEN
_originalOverallResult := inoResult;
END_IF


IF (NOT __ISVALIDREF(_inspectorTask.InspectionData)) THEN
inoResult.Result := eOverallResult.NoAction;
Expand Down
Loading