Skip to content

Fix accumulation of failure descriptions and error codes in UpdateDes… #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterbarancek merged 1 commit into from
Jun 8, 2026
Merged

Fix accumulation of failure descriptions and error codes in UpdateDes… #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/TcoInspectors/src/XAE/XAE/TcoInspectors/POUs/TcoInspectionGroup/TcoInspectionGroup.TcPOU
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,8 +542,17 @@ CASE _currentRunResult.Result OF
eOverallResult.Failed:
_refOverallResult:=_originalOverallResult;
_refOverallResult.Result := eOverallResult.Failed;
_refOverallResult.Failures := concat(concat(_refOverallResult.Failures,';'), _currentRunResult.Failures);
_refOverallResult.ErrorCodes := concat(concat(_refOverallResult.ErrorCodes,';'),_currentRunResult.ErrorCodes);
IF _refOverallResult.Failures<>'' THEN
_refOverallResult.Failures := concat(concat(_refOverallResult.Failures,';'), _currentRunResult.Failures);
ELSE
_refOverallResult.Failures := _currentRunResult.Failures;
END_IF;

IF _refOverallResult.ErrorCodes<>'' THEN
_refOverallResult.ErrorCodes := concat(concat(_refOverallResult.ErrorCodes,';'),_currentRunResult.ErrorCodes);
ELSE
_refOverallResult.ErrorCodes := _currentRunResult.ErrorCodes;
END_IF;
Comment on lines +545 to +555
END_CASE


Expand Down
11 changes: 9 additions & 2 deletions src/TcoInspectors/tests/PlcUnitTests/TcoInspectionGroupTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,14 @@ public void SetUp()

container.ExecuteProbeRun(1, 0);
InspectorContainer._overallResult.Result.Synchron = 0;
container._sut._overallResult.Result.Synchron = 0;
container._sut._overallResult.Result.Synchron = 0;

InspectorContainer._overallResult.Failures.Synchron = "";
InspectorContainer._overallResult.ErrorCodes.Synchron = "";
InspectorContainer._sut._overallResult.Failures.Synchron = "";
InspectorContainer._sut._overallResult.ErrorCodes.Synchron = "";


}


Expand Down Expand Up @@ -309,7 +316,7 @@ public void inspect_failed_description_group_failed()
var initialState = InspectorContainer._coordinator._state.Synchron;
var expectedState = (short)(initialState - 10);
InspectorContainer._retryState.Synchron = expectedState;

Assert.AreEqual("", InspectorContainer._sut._overallResult.Failures.Synchron);
InspectorContainer.ExecuteProbeRun((int)eInspectionGroupTests.UpdateComprehensiveResultDescriptions,
() => {
Task.Delay(failTime).Wait();
Expand Down
Loading