Fix/recttransform null guard#25
Open
Krono159 wants to merge 2 commits into
Open
Conversation
- Fix: MenuButton.rectTransform is now explicitly assigned from REPOButton.Awake() — prevents NullReferenceException in SemiFunc.UIGetRectTransformPositionOnScreen when hovering over admin menu buttons. This occurs because in recent game versions, MenuButton.Awake() does not guarantee the rectTransform field is initialized in time.
…d bug with menu creation on latest version
Author
|
first time trying to merge, sorry for the mess in the previous request ^^' |
There was a problem hiding this comment.
Pull request overview
This PR addresses a NullReferenceException caused by MenuButton.rectTransform not being initialized early enough in newer game versions, by explicitly assigning the rectTransform field from REPOButton.Awake() via reflection.
Changes:
- Added a reflected
FieldInfohandle forMenuButton.rectTransform. - Updated
REPOButton.Awake()to setMenuButton.rectTransformwhen theMenuButtoncomponent is present.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
MenuLib/REPOReflection.cs |
Adds a reflected field reference for MenuButton.rectTransform so it can be assigned explicitly. |
MenuLib/MonoBehaviors/REPOButton.cs |
Sets MenuButton.rectTransform during Awake() to prevent hover-time NREs in UI positioning code. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
idk why copilot started doing this for me... i'll try to disable it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: MenuButton.rectTransform is now explicitly assigned from REPOButton.Awake() — prevents NullReferenceException in SemiFunc.UIGetRectTransformPositionOnScreen when hovering over admin menu buttons. This occurs because in recent game versions, MenuButton.Awake() does not guarantee the rectTransform field is initialized in time.