Add notification icon fallback chain for Firebase and standard Android conventions#1008
Open
davidtruong wants to merge 1 commit intomasterfrom
Open
Add notification icon fallback chain for Firebase and standard Android conventions#1008davidtruong wants to merge 1 commit intomasterfrom
davidtruong wants to merge 1 commit intomasterfrom
Conversation
Before falling back to the app launcher icon (which shows as a white square on Android 5.0+), the SDK now checks these standard locations: 1. Firebase default notification icon metadata 2. @drawable/notification_icon (Expo convention) 3. @drawable/ic_notification (common Android convention) This allows the SDK to automatically use notification icons configured through Expo, Firebase, or other common frameworks without requiring manual iterable_notification_icon configuration. Fixes #976 https://claude.ai/code/session_01JNHse78oK4wYWnqfeCtwm6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
✏️ Description
Implements a comprehensive notification icon fallback chain to support multiple icon configuration conventions. The SDK now checks for notification icons in the following priority order:
iterable_notification_icon)com.google.firebase.messaging.default_notification_icon)notification_icon)ic_notification)This change improves compatibility with Firebase Cloud Messaging and other common Android notification icon conventions, allowing developers to configure notification icons using standard practices without requiring Iterable-specific metadata.
Changes Made
getIconId()method to check Firebase metadata and standard Android drawable resources before falling back to app iconTest Plan
Added unit tests that verify the icon fallback chain works correctly at each level. Existing tests continue to pass.
https://claude.ai/code/session_01JNHse78oK4wYWnqfeCtwm6