[SDK-386] embedded card improvements#1009
Open
franco-zalamena-iterable wants to merge 4 commits intomasterfrom
Open
[SDK-386] embedded card improvements#1009franco-zalamena-iterable wants to merge 4 commits intomasterfrom
franco-zalamena-iterable wants to merge 4 commits intomasterfrom
Conversation
franco-zalamena-iterable
force-pushed
the
SDK-386-embedded-card-image-height
branch
from
c1fb274 to
e35c809
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
✏️ Description
Improvements to the Card Embedded View Image and buttons configurations.
NEW image scale type config option for the embedded view
The Card Embedded view currently had display issues for the buttons, with them showing up with a start padding that made them unaligned. To match the campaign preview they are now aligned to the left padding from the card itself.
The image from the card embedded now has an aspect ratio field that can be configured by the new image scale type field
closes #997