[SDK-337] Fix for status bar overlap on in-app messages#988
Open
franco-zalamena-iterable wants to merge 4 commits intomasterfrom
Open
[SDK-337] Fix for status bar overlap on in-app messages#988franco-zalamena-iterable wants to merge 4 commits intomasterfrom
franco-zalamena-iterable wants to merge 4 commits intomasterfrom
Conversation
franco-zalamena-iterable
force-pushed
the
SDK-337-in-app-close-button-position
branch
from
79b5978 to
44f314a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| private boolean hasEdgeToEdgeLegacyFlags(Activity activity) { | ||
| int flags = activity.getWindow().getDecorView().getSystemUiVisibility(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
iterableapi/src/main/java/com/iterable/iterableapi/IterableInAppFragmentHTMLNotification.java
Show resolved
Hide resolved
iterableapi/src/main/java/com/iterable/iterableapi/IterableInAppFragmentHTMLNotification.java
Show resolved
Hide resolved
| } | ||
|
|
||
| @SuppressWarnings("deprecation") | ||
| private void configureSystemBarsFollowingApp(Window window, InAppLayout layout) { |
Check notice
Code scanning / CodeQL
Useless parameter
franco-zalamena-iterable
changed the title
…r in the app. Changing default bahaviour to follow the app layout
franco-zalamena-iterable
force-pushed
the
SDK-337-in-app-close-button-position
branch
from
de2b8af to
eccf755
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
✏️ Description
We had a problem with fullscreen in-app messages, some clients were getting the close button behind the status bar and losing the ability to close the message.
The flag
FLAG_FULLSCREENwas just making the content appear under the status bar but blocking clicks and obstructing the view.The fix is to have new flags:
These are meant to control the way the in-app will be drawn in relation to the status bar of the app. The default behavior will be FOLLOW_APP_LAYOUT so clients implementing it will not have to think about it, but if the app already accounts for the previous EDGE_TO_EDGE, you can have it as FORCE_EDGE_TO_EDGE.