feat(ci): guard against new *-coverage.test.ts bolt-on files#8589
Merged
Conversation
Adds scripts/check-coverage-bolt-on-filenames.ts, a drift-style check (alongside docs:drift-check/manifest:drift-check/engine-parity:drift-check) that fails when a test file matches *-coverage.test.ts or *-branch-coverage.test.ts, with an allowlist for genuine exceptions (rees-coverage-script.test.ts tests scripts/rees-coverage.js, real coverage tooling -- the name is a coincidence). Wired into test:ci right after docs:drift-check. This closes out epic #8574: the whole existing bolt-on family (predicted-gate-engine-coverage.test.ts, reward-risk-engine-branch- coverage.test.ts, focus-manifest-engine-branch-coverage.test.ts, signals-coverage.test.ts) has now merged, so the check lands green. Also updates the contributing-to-loopover skill (SKILL.md Phase 3 + reference.md's CI check table) so future contributors are told to extend a module's existing suite instead of bolting on a new coverage-named file.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
loopover-ui | 200b3ee | Commit Preview URL Branch Preview URL |
Jul 24 2026, 10:56 PM |
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Bundle ReportBundle size has no change ✅ |
loopover-orb
Bot
added
the
gittensor:bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8589 +/- ##
=======================================
Coverage 92.54% 92.54%
=======================================
Files 796 796
Lines 79850 79850
Branches 24135 24135
=======================================
Hits 73899 73899
Misses 4802 4802
Partials 1149 1149
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8580. Last piece of the #8574 epic.
Summary
Adds
scripts/check-coverage-bolt-on-filenames.ts, a drift-style check (same shape asdocs:drift-check/manifest:drift-check/engine-parity:drift-check) that fails when a test file matches*-coverage.test.tsor*-branch-coverage.test.ts, with an allowlist for genuine exceptions (rees-coverage-script.test.tstestsscripts/rees-coverage.js, real coverage tooling — the name is a coincidence). Wired intotest:ciright afterdocs:drift-check.The whole existing bolt-on family (
predicted-gate-engine-coverage.test.ts,reward-risk-engine-branch-coverage.test.ts,focus-manifest-engine-branch-coverage.test.ts,signals-coverage.test.ts) has now merged via #8581/#8582/#8584/#8586, so this check lands green.Also updates the contributing-to-loopover skill (
SKILL.mdPhase 3 +reference.md's CI check table) so future contributors are pointed at extending a module's existing suite instead of bolting on a new coverage-named file.Test plan
npm run coverage-boltons:check— clean against current mainnpx vitest run test/unit/check-coverage-bolt-on-filenames-script.test.ts— 8/8 passnpm run typecheck— clean