Skip to content

fix: allow GROUPS as identifier by making it a non-reserved keyword (#2473) #2474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manticore-projects merged 1 commit into from
Aug 16, 2026
+12 −1
Merged

fix: allow GROUPS as identifier by making it a non-reserved keyword (#2473) #2474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1287,6 +1287,7 @@ String NonReservedWord() :
| tk=<K_FULLTEXT:"FULLTEXT">
| tk=<K_FUNCTION:"FUNCTION">
| tk=<K_GRANT:"GRANT">
| tk=<K_GROUPS:"GROUPS">
| tk=<K_GROUP_CONCAT:"GROUP_CONCAT">
| tk=<K_GUARD:"GUARD">
| tk=<K_HASH:"HASH">
Expand Down Expand Up @@ -1577,7 +1578,6 @@ TOKEN: /* Reserved SQL Keywords and structural tokens */
| <K_GLOBAL:"GLOBAL">
| <K_GROUP:"GROUP">
| <K_GROUPING:"GROUPING">
| <K_GROUPS:"GROUPS">
| <K_HAVING:"HAVING">
| <K_IF:"IF">
| <K_IIF:"IIF">
Expand Down
11 changes: 11 additions & 0 deletions src/test/java/net/sf/jsqlparser/statement/KeywordsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,15 @@ public void testCombinedTokenKeywords() throws JSQLParserException {
String sqlStr = "SELECT current_date(3)";
assertSqlCanBeParsedAndDeparsed(sqlStr, true);
}

// #2473: GROUPS is a non-reserved keyword in PostgreSQL and must stay usable as an
// identifier, although it also introduces the GROUPS window frame unit.
@Test
public void testGroupsAsIdentifier() throws JSQLParserException {
assertSqlCanBeParsedAndDeparsed("SELECT groups FROM mytable", true);
assertSqlCanBeParsedAndDeparsed("SELECT * FROM groups", true);
assertSqlCanBeParsedAndDeparsed("SELECT a AS groups FROM mytable", true);
assertSqlCanBeParsedAndDeparsed("SELECT a groups FROM mytable", true);
assertSqlCanBeParsedAndDeparsed("CREATE TABLE mytable (groups INT)", true);
}
}
Loading