test: add unit tests for HexDump and useFileBinaryPreviewQuery#351
Merged
allison-truhlar merged 1 commit intomainfrom Apr 10, 2026
Merged
test: add unit tests for HexDump and useFileBinaryPreviewQuery#351allison-truhlar merged 1 commit intomainfrom
allison-truhlar merged 1 commit intomainfrom
Conversation
- hexDump.test.tsx: 11 tests covering offset/hex/ASCII formatting, mid-row gap, truncation message, non-printable byte substitution, empty input, and multi-row output - fileBinaryPreviewQuery.test.tsx: 7 tests covering 206/200 responses, error state, disabled states (enabled=false, undefined fspName), Range header, and credentials Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds unit tests for the two new items introduced in the binary file display feature:
hexDump.test.tsx(11 tests) — covers theHexDumpcomponent:totalFileSize > bytes.length.in ASCII columnfileBinaryPreviewQuery.test.tsx(7 tests) — coversuseFileBinaryPreviewQuery:Uint8Arrayfrom a 206 Partial Content responseUint8Arrayfrom a 200 OK response (server ignores Range)enabledisfalsefspNameisundefinedRange: bytes=0-511headercredentials: 'include'in the requestTest plan
pixi run test-frontend— 18 test files, 124 tests, all passing🤖 Generated with Claude Code