Remove trivial folder#499
Merged
Merged
Conversation
Collaborator
nathanwbrei
commented
May 25, 2026
nathanwbrei
commented
- Topologies no longer pull in a no-op folder
- Reworks JTopologyBuilder::CreateTopology to eventually support more complex topologies, e.g. multi-level unfolders/folders
- Adds support for auto-wiring multi-level event sources
- Converts JComponentManager to PascalCase
- Removes flawed JEvent::RefToSelf mechanism
- Fixes a bug when attempting to run JEventSource::ProcessParallel with multiple event sources in play
This mechanism is both flawed and very confusing. It fails in one particular case: When all child events are processed by a JEventFolder before the parent event gets released from the JEventUnfolder
This reduces confusion (vs JEventSource::SetLevel), is more technically correct, and lets JTopologyBuilder clearly distinguish between "parent sources" and "child sources"
Replaced by CreateTopologyFromScratch() which is capable of working with multilevel sources/folders/unfolders
nathanwbrei
force-pushed
the
nbrei_remove_trivial_folder
branch
from
cd5b06b to
83ef629
Compare
TimesliceExample requires an additional flag now to decide whether to include the unfolder or not. Previously, specifying an Unfolder with no parent source would lead to the unfolder being ignored. Now, however, specifying an Unfolder with a child source and no parent source is a valid and useful topology.
This is used in one place by halld_recon, apparently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.