Skip to content

fix: BUILD_WITH_INSTALL_RPATH=FALSE#503

Open
wdconinc wants to merge 1 commit into
JeffersonLab:masterfrom
wdconinc:build-with-install-rpath
Open

fix: BUILD_WITH_INSTALL_RPATH=FALSE#503
wdconinc wants to merge 1 commit into
JeffersonLab:masterfrom
wdconinc:build-with-install-rpath

Conversation

@wdconinc
Copy link
Copy Markdown
Member

This PR ensures that the typical cmake, make, ctest, make install actually works. BUILD_WITH_INSTALL_RPATH=TRUE results in the old/previous libraries being used instead of the newly compiled ones.

Copilot AI review requested due to automatic review settings May 27, 2026 23:53
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Switches CMake target RPATH handling from install-time RPATH to build-time RPATH for JANA libraries, plugins, and their associated tests, so binaries use build-tree RPATHs during development and only get the install RPATH applied at install time.

Changes:

  • Set BUILD_WITH_INSTALL_RPATH to FALSE for JANA libraries and their test targets.
  • Set BUILD_WITH_INSTALL_RPATH to FALSE for JANA plugins and their test targets.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
cmake/AddJanaLibrary.cmake Disable building libraries and tests with the install RPATH baked in.
cmake/AddJanaPlugin.cmake Disable building plugins and tests with the install RPATH baked in.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants