Skip to content

fix: use TARGET_FILE:jana to avoid using jana in path#504

Open
wdconinc wants to merge 1 commit into
JeffersonLab:masterfrom
wdconinc:target-file-jana
Open

fix: use TARGET_FILE:jana to avoid using jana in path#504
wdconinc wants to merge 1 commit into
JeffersonLab:masterfrom
wdconinc:target-file-jana

Conversation

@wdconinc
Copy link
Copy Markdown
Member

This PR ensures that tests use the actual built target jana executable instead of picking what's in the path.

Copilot AI review requested due to automatic review settings May 27, 2026 23:58
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Replaces hardcoded jana command references in CMake add_test invocations with the generator expression $<TARGET_FILE:jana>, ensuring tests use the built executable target rather than relying on PATH lookup or install prefix paths.

Changes:

  • Substitutes jana / ${CMAKE_INSTALL_PREFIX}/bin/jana with $<TARGET_FILE:jana> across multiple add_test commands.
  • Applies the change consistently to plugin and example test definitions.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/plugins/janadot/CMakeLists.txt Use TARGET_FILE generator expression for janadot test
src/plugins/JTest/CMakeLists.txt Use TARGET_FILE generator expression for JTest test
src/examples/tutorial_with_lightweight_datamodel/02_random_hit_source/CMakeLists.txt Use TARGET_FILE for lw smoketest
src/examples/misc/Tutorial/CMakeLists.txt Use TARGET_FILE for Tutorial test
src/examples/misc/TimesliceExample/CMakeLists.txt Replace install-prefix path with TARGET_FILE for both timeslice tests
src/examples/misc/RootDatamodelExample/CMakeLists.txt Use TARGET_FILE for rootdatamodel test
src/examples/misc/EventGroupExample/CMakeLists.txt Use TARGET_FILE for eventgroup test
src/examples/misc/DstExample/CMakeLists.txt Use TARGET_FILE for dst test

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants