fix: use TARGET_FILE:jana to avoid using jana in path#504
Open
wdconinc wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Replaces hardcoded jana command references in CMake add_test invocations with the generator expression $<TARGET_FILE:jana>, ensuring tests use the built executable target rather than relying on PATH lookup or install prefix paths.
Changes:
- Substitutes
jana/${CMAKE_INSTALL_PREFIX}/bin/janawith$<TARGET_FILE:jana>across multipleadd_testcommands. - Applies the change consistently to plugin and example test definitions.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/plugins/janadot/CMakeLists.txt | Use TARGET_FILE generator expression for janadot test |
| src/plugins/JTest/CMakeLists.txt | Use TARGET_FILE generator expression for JTest test |
| src/examples/tutorial_with_lightweight_datamodel/02_random_hit_source/CMakeLists.txt | Use TARGET_FILE for lw smoketest |
| src/examples/misc/Tutorial/CMakeLists.txt | Use TARGET_FILE for Tutorial test |
| src/examples/misc/TimesliceExample/CMakeLists.txt | Replace install-prefix path with TARGET_FILE for both timeslice tests |
| src/examples/misc/RootDatamodelExample/CMakeLists.txt | Use TARGET_FILE for rootdatamodel test |
| src/examples/misc/EventGroupExample/CMakeLists.txt | Use TARGET_FILE for eventgroup test |
| src/examples/misc/DstExample/CMakeLists.txt | Use TARGET_FILE for dst test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that tests use the actual built target jana executable instead of picking what's in the path.