fix: use consistent/non-empty test collection names#506
Open
wdconinc wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the tutorial example pipeline to use the "rechits" databundle name instead of relying on the prior "raw" name or the default/empty tag in tests.
Changes:
- Switch
CsvWriterto request calorimeter hits from the"rechits"databundle. - Update protocluster factory tests to insert hits under
"rechits"instead of the default/empty tag.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/examples/tutorial_with_lightweight_datamodel/05_csv_file_writer/CsvWriter.cc | Changes requested databundle name for calorimeter hit collections to "rechits". |
| src/examples/tutorial_with_lightweight_datamodel/03_protocluster_factory/Protocluster_tests.cc | Updates unit tests to insert hits into the "rechits" databundle explicitly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| m_event_header_in.SetOptional(true); | ||
| m_calo_hit_collections_in.SetRequestedDatabundleNames({"raw"}); | ||
| m_calo_hit_collections_in.SetRequestedDatabundleNames({"rechits"}); |
| auto event = std::make_shared<JEvent>(&app); | ||
|
|
||
| event->Insert(make_two_cluster_hits(), ""); | ||
| event->Insert(make_two_cluster_hits(), "rechits"); |
| auto event = std::make_shared<JEvent>(&app); | ||
|
|
||
| event->Insert(make_two_cluster_hits(), ""); | ||
| event->Insert(make_two_cluster_hits(), "rechits"); |
| auto event = std::make_shared<JEvent>(&app); | ||
|
|
||
| event->Insert(make_two_cluster_hits(), ""); | ||
| event->Insert(make_two_cluster_hits(), "rechits"); |
| auto event = std::make_shared<JEvent>(&app); | ||
|
|
||
| event->Insert(make_two_cluster_hits(), ""); | ||
| event->Insert(make_two_cluster_hits(), "rechits"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure that test 03 writes the same name that 05 requests, without empty strings.