Skip to content

Bump Dock.Avalonia and Dock.Avalonia.Themes.Fluent - #1339

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/nuget/multi-c98f40e346
Closed

Bump Dock.Avalonia and Dock.Avalonia.Themes.Fluent#1339
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/nuget/multi-c98f40e346

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 19, 2026

Copy link
Copy Markdown

Updated Dock.Avalonia from 12.0.0.2 to 12.1.0.2.

Release notes

Sourced from Dock.Avalonia's releases.

12.1.0.2

What's Changed

New Contributors

Full Changelog: wieslawsoltes/Dock@v12.1.0.1...v12.1.0.2

12.1.0.1

What's Changed

Full Changelog: wieslawsoltes/Dock@v12.1.0...v12.1.0.1

12.1.0

What's Changed

Full Changelog: wieslawsoltes/Dock@v12.0.0.2...v12.1.0

Commits viewable in compare view.

Updated Dock.Avalonia.Themes.Fluent from 12.0.0.2 to 12.1.0.2.

Release notes

Sourced from Dock.Avalonia.Themes.Fluent's releases.

12.1.0.2

What's Changed

New Contributors

Full Changelog: wieslawsoltes/Dock@v12.1.0.1...v12.1.0.2

12.1.0.1

What's Changed

Full Changelog: wieslawsoltes/Dock@v12.1.0...v12.1.0.1

12.1.0

What's Changed

Full Changelog: wieslawsoltes/Dock@v12.0.0.2...v12.1.0

Commits viewable in compare view.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps Dock.Avalonia from 12.0.0.2 to 12.1.0.2
Bumps Dock.Avalonia.Themes.Fluent from 12.0.0.2 to 12.1.0.2

---
updated-dependencies:
- dependency-name: Dock.Avalonia
  dependency-version: 12.1.0.2
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: Dock.Avalonia.Themes.Fluent
  dependency-version: 12.1.0.2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added .NET Pull requests that update .NET code dependencies Pull requests that update a dependency file labels Aug 19, 2026
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code labels Aug 19, 2026
@JoshuaRowePhantom

Copy link
Copy Markdown
Owner

HELD — not taken. Evaluated under #1346 on branch fix/1346-dependabot-upgrades.

I moved all five Dock.* pins (Dock.Avalonia, Dock.Avalonia.Themes.Fluent, Dock.Model.Avalonia, Dock.Model.Mvvm, Dock.Serializer.SystemTextJson) from 12.0.0.2 to 12.1.0.2 together and validated against the Avalonia 12.1.1 landed via #1336. The build succeeded, but Dock.Serializer.SystemTextJson 12.1.0.2 changed $id/$ref reference handling and throws on deserializing the persisted real dock layout:

System.Text.Json.JsonException : The value of the '$id' metadata property '1' conflicts with an existing identifier. Path: $.Window.Layout.VisibleDockables[0]

This fails Phantom.Workspaces.Tests.WorkspaceDockPersistenceTests.WorkspaceDockPersistence_LoadRealLayout1334_HealsTo11Docs. Reverting only the Dock.* pins back to 12.0.0.2 (keeping Avalonia 12.1.1) makes the dock persistence/tab-switching/layout tests green again (confirmed, incl. 10x stability). The deliberate Dock.* = 12.0.0.2 pin is therefore retained.

Note this PR also only bumps 2 of the 5 Dock.* pins, which would desync the set regardless. Closing in favor of the local integration flow; not merged here. Dependabot branch left intact. Re-open/re-evaluate when a Dock release restores compatible reference serialization for the persisted layout.

@dependabot @github

dependabot Bot commented on behalf of github Aug 19, 2026

Copy link
Copy Markdown
Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/nuget/multi-c98f40e346 branch August 19, 2026 16:57
JoshuaRowePhantom added a commit that referenced this pull request Aug 19, 2026
Applies Dependabot #1336 (avalonia group, 8 packages) locally via the features
integration flow. #1227 is a strict subset (Avalonia.Headless/.XUnit) and is subsumed.

Dock.* is deliberately HELD at 12.0.0.2 (Dependabot #1339 not taken): bumping the five
Dock.* pins to 12.1.0.2 makes Dock.Serializer.SystemTextJson throw
'The value of the \ metadata property conflicts with an existing identifier' when
deserializing the persisted real dock layout, failing
WorkspaceDockPersistenceTests.WorkspaceDockPersistence_LoadRealLayout1334_HealsTo11Docs.
Avalonia 12.1.1 alone leaves all tests green.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant