Conversation
Apple's metal compiler emits the architecture as air64_v<major><minor> (air64_v26 for AIR 2.6, etc.), and its tools derive the expected AIR version from the triple, flagging a mismatch with the air.version module metadata. Match that for AIR 2.6 and up; older toolchains used the plain air64, so keep that for earlier targets. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Apple's metal compiler records the compile options it was invoked with in an air.compile_options named metadata node. Emit the same: denorms_disable and framebuffer_fetch_enable to match its defaults, and fast_math_enable or fast_math_disable depending on target.fastmath, which already selects the relaxed air.fast_* math device functions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #833 +/- ##
==========================================
+ Coverage 79.36% 79.41% +0.05%
==========================================
Files 25 25
Lines 4584 4591 +7
==========================================
+ Hits 3638 3646 +8
+ Misses 946 945 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.