Add support for more Distributions#44
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 76 108 +32
=========================================
+ Hits 76 108 +32 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands Colorfy’s Distributions.jl integration by adding specialized color representations for additional distribution types and extending test coverage to validate the new behavior.
Changes:
- Updated the Distributions extension to support
Normal,Bernoulli,Categorical, plus a heterogeneous-distribution fallback. - Switched the
Normalmapping to use entropy-derived transparency (instead of scale) and added entropy-based transparency tests for discrete distributions. - Added tests for heterogeneous distribution vectors and ensured missing values continue to map to transparent.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
ext/ColorfyDistributionsExt.jl |
Adds new repr methods for multiple distributions and a fallback for vectors of distributions. |
test/runtests.jl |
Extends the Distributions testset to cover Normal/Bernoulli/Categorical, heterogeneous vectors, and missing handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.