WIP: Cubic Hermite Splines (and monotone splines)#110
Open
cc7768 wants to merge 1 commit intoJuliaMath:masterfrom
Open
WIP: Cubic Hermite Splines (and monotone splines)#110cc7768 wants to merge 1 commit intoJuliaMath:masterfrom
cc7768 wants to merge 1 commit intoJuliaMath:masterfrom
Conversation
Contributor
|
Nice! Hermite splines are not inherently cubic, right? How difficult would it be to generalize the implementation to support (at least) lower orders too? |
Author
|
Hermite splines aren't inherently cubic, but that seems to be the main use case. I don't know how hard it would be to generalize the implementation:
Will let you know how much effort implementing the quadratic version looks like it will be as I have time to work on this. |
|
Why this one not merged at that time? It could be worth to merge and add Linear & quadratic later. |
Author
|
I haven't made time to finish this, so there isn't anything worth merging. Likely won't have a chance to do this before new year. Depends on how some other things progress. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress with @sglyon. This PR (when it is finished) would address #105
Plan: Cubic Hermite splines use information about both the value and derivative of the function. The plan is to allow for users to give both pieces of information if they would like, but if they only give values then we can construct an approximation of the derivative for them (using a specific approximation that preserves monotonicity).
Progress: A long way to go, but I thought I would open PR so no work got duplicated (and as a commitment device to myself). We have a (very) crude 1d implementation that seems to work for interpolating data.
Next: Our next step is that we need to plug this into the
Interpolations.jlframework i.e. make sure we write the right indexing functions etc... Will keep people updated.