Skip to content

Add full tests + Ruff autofixes#13

Merged
Kalmat merged 6 commits into
masterfrom
Add-full-tests-+-Ruff-autofixes
Jun 25, 2026
Merged

Add full tests + Ruff autofixes#13
Kalmat merged 6 commits into
masterfrom
Add-full-tests-+-Ruff-autofixes

Conversation

@Avasam

@Avasam Avasam commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Added full test suite + Autofixable code modernizations from Ruff
No manual code change.


Account for lack of primary monitor in tests

@Avasam Avasam requested a review from Kalmat June 24, 2026 18:14
@Avasam Avasam mentioned this pull request Jun 24, 2026
@Avasam

Avasam commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator Author

ohh, interesting, Linux test failing I think because no virtual monitor is being returned as the primary so _XgetMonitorData fails the monitor.primary == 1 and returns None. Not immediatly sure if that's a bad test expectation, or if _XgetMonitorData should have a fallback.
@Kalmat your know your API and intent better than I do !

@Kalmat

Kalmat commented Jun 25, 2026

Copy link
Copy Markdown
Owner

It should definitely have a fallback in case there is no primary monitor. Not the typical case, but totally acceptable in Linux (not in Windows nor macOS). I will work on it after we finish.

Thanks!!

@Kalmat Kalmat merged commit 37d3ac6 into master Jun 25, 2026
40 checks passed
@Avasam Avasam deleted the Add-full-tests-+-Ruff-autofixes branch June 25, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants