Skip to content

[NET-920] fix: Add missing escaped param in record_exception #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akash-vijay-kv wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[NET-920] fix: Add missing escaped param in record_exception #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion netra/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,7 @@ def record_exception(
cls,
exception: BaseException,
attributes: Optional[Dict[str, Any]] = None,
escaped: Optional[bool] = False,
) -> None:
"""Record a caught exception on the currently active span.

Expand Down Expand Up @@ -454,7 +455,7 @@ def process_order(order_id: str) -> str:
type(exception),
)
return
SessionManager.record_exception(exception, attributes=attributes)
SessionManager.record_exception(exception, attributes=attributes, escaped=escaped)

@classmethod
def add_conversation(cls, conversation_type: ConversationType, role: str, content: Any) -> None:
Expand Down
3 changes: 2 additions & 1 deletion netra/session_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,6 +520,7 @@ def set_attribute_on_root_span(cls, attr_key: str, attr_value: Any) -> None:
def record_exception(
exception: BaseException,
attributes: Optional[Dict[str, Any]] = None,
escaped: Optional[bool] = False,
) -> None:
"""Record a caught exception on the currently active span.

Expand All @@ -539,7 +540,7 @@ def record_exception(
logger.warning("record_exception: no active recording span to record exception on")
return

span.record_exception(exception, attributes=attributes)
span.record_exception(exception, attributes=attributes, escaped=escaped)
span.set_status(trace.Status(trace.StatusCode.ERROR, str(exception)))
span.set_attribute(f"{Config.LIBRARY_NAME}.error_message", str(exception))
except Exception:
Expand Down