Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/early-buttons-pay.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@khanacademy/perseus": patch
---

Fix image bug by batching setState calls in setupGraphie
17 changes: 11 additions & 6 deletions packages/perseus/src/components/svg-image.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,7 @@ class SvgImage extends React.Component<Props, State> {
graphie: any,
options: any,
) => {
const newLabelsRendered: LabelsRenderedMap = {};
_.map(options.labels, (labelData) => {
const {JIPT} = getDependencies();
if (JIPT.useJIPT && this.state.labelDataIsLocalized) {
Expand Down Expand Up @@ -357,13 +358,17 @@ class SvgImage extends React.Component<Props, State> {
label.css(styleName, styleValue);
});
}
this.setState({
labelsRendered: {
...this.state.labelsRendered,
[labelData.content]: true,
},
});
newLabelsRendered[labelData.content] = true;
});
// Note: Using a function is the preferred method of combining previous
// state with the new update
// (docs: https://react.dev/reference/react/Component#setstate-parameters)
this.setState((prev) => ({
labelsRendered: {
...prev.labelsRendered,
...newLabelsRendered,
},
}));
};

// Try to parse a CSS value as pixels. Returns null if the parameter string
Expand Down
Loading