Tokens: Change background.neutral.strong in Thunderblocks#2977
Tokens: Change background.neutral.strong in Thunderblocks#2977
background.neutral.strong in Thunderblocks#2977Conversation
🦋 Changeset detectedLatest commit: f5dcb4b The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: 0 B Total Size: 123 kB ℹ️ View Unchanged
|
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (374d3f4) and published all packages with changesets to npm. You can install the packages in ./dev/tools/deploy_wonder_blocks.js --tag="PR2977"Packages can also be installed manually by running: pnpm add @khanacademy/wonder-blocks-<package-name>@PR2977 |
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-ospuimnbbr.chromatic.com/ Chromatic results:
|
beaesguerra
force-pushed
the
token-migration-pt-2
branch
from
32b8003 to
8957de0
Compare
…ound.neutral.strong` from `black_100` to `gray_10`. If consumers are needing to use the `black_100` value, migrate it to `background.base.strong`
beaesguerra
force-pushed
the
token-migration-pt-2
branch
from
8957de0 to
d5097bd
Compare
…o token-migration-pt-2
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
|
Here's the associated |
beaesguerra
left a comment
beaesguerra
left a comment
There was a problem hiding this comment.
Looks good to me, including the Chromatic snapshots! Thanks for taking this on @jandrade ! 😄
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2977 +/- ##
============================
============================
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
3 participants
Summary:
Now that
semanticColor.core.background.base.strongis updated to a dark color in #2970, we can updatesemanticColor.core.background.neutral.strongin thethunderblockstheme fromblack_100togray_10.Note: If current usage in projects are expecting the value to be
black_100, it should be updated to usebackground.base.stronginstead for the TB themeIssue: WB-2271
Test plan:
Confirm token change is expected and changes in Chromatic are expected