Fix sub_group_inverse_ballot testing#2695
Open
StuartDBrady wants to merge 4 commits into
Open
Conversation
Also rename rft_arith to rft_bit_ops, test_params_arith to test_params_bit_ops, and sub_group_ballot_bit_scan_find_source to sub_group_ballot_bit_ops_source. Signed-off-by: Stuart Brady <stuart.brady@arm.com>
Signed-off-by: Stuart Brady <stuart.brady@arm.com>
Signed-off-by: Stuart Brady <stuart.brady@arm.com>
The previous test would still pass even if the implementation always returned true. Now that we use BALLOT_BIT_OPS for inverse_ballot, we no longer need sub_group_inverse_ballot_source. We use sub_group_ballot_bit_ops_source instead. Signed-off-by: Stuart Brady <stuart.brady@arm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous test would still pass even if the implementation always
returned true.
Now that we use BALLOT_BIT_OPS for inverse_ballot, we no longer need
sub_group_inverse_ballot_source. We use sub_group_ballot_bit_ops_source
instead.
This change also renames BALLOT_COUNT_SCAN_FIND to BALLOT_BIT_OPS,
along with renaming rft_arith to rft_bit_ops, test_params_arith to
test_params_bit_ops, and sub_group_ballot_bit_scan_find_source to
sub_group_ballot_bit_ops_source.
It also uses cl_uint4_to_bs128 in BALLOT_BIT_OPS::chk and adds
static_asserts for BallotOp values.