Revert "scripts: NULL empty strings array"#380
Closed
spencer-lunarg wants to merge 1 commit into
Closed
Conversation
This reverts commit a96bd49.
Contributor
|
Pretty much any test should trigger that issue with self validation, as long as the |
Contributor
|
Also this fix aside, we should not try to allocate memory for empty arrays, so I would vote for keeping those changes anyway |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit a96bd49.
see KhronosGroup/Vulkan-ValidationLayers#12185 (review)
@arno-lunarg which test was giving you a self validation error... that test might be just wrong now, I will not merge this yet, but want to have this ready as I don't agree with the previous change
(sorry, I'm already pissed the working group decided to mess around with
ppEnabledLayerNamesafter it was not broken for 10 years and now we are all having to play stupid code gen dances around a fake problem)