Skip to content

feat(web): make customer survey non-blocking#4482

Open
Drixled wants to merge 3 commits into
mainfrom
remove-customer-source-survey
Open

feat(web): make customer survey non-blocking#4482
Drixled wants to merge 3 commits into
mainfrom
remove-customer-source-survey

Conversation

@Drixled

@Drixled Drixled commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Moves the customer-source survey out of the onboarding path and into the authenticated app shell as a small, dismissible card. The existing persistence behavior stays the same, while the legacy survey URL now forwards users to its validated destination instead of blocking navigation.

What changed

  • restyle the existing customer-source survey as a compact, dismissible card in the authenticated app shell
  • remove the full-page survey redirect from onboarding navigation
  • preserve the existing database field and submit/dismiss mutations
  • forward the legacy survey URL to its validated destination
  • update the existing account-verification assertions for the non-blocking flow
  • remove the obsolete full-page survey E2E and redirect-helper tests

Visual review

The UI change is contained to the authenticated survey card. This PR does not include before/after screenshot assets.

Scope

  • no database, API, telemetry, seed, or local-environment changes
  • no new test files
  • no changes to the existing survey persistence contract

Validation

  • pnpm format
  • pnpm --filter web test -- "src/tests/account-verification-redirect.test.ts"
  • pnpm --filter web typecheck
  • pnpm --filter web lint

@Drixled Drixled changed the title feat(web): replace blocking customer survey feat(web): make customer survey non-blocking Jul 10, 2026
</div>
</PrefetchedOrganizations>
</SidebarProvider>
<CustomerSourceSurvey />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: Survey card is not excluded from onboarding/welcome flows

<CustomerSourceSurvey /> is mounted unconditionally in the (app) layout, so it renders on every route under this layout, including /gastown/onboarding (apps/web/src/app/(app)/gastown/onboarding) and the org welcome flow (apps/web/src/app/(app)/organizations/[id]/welcome). The PR description states a goal of "stop the survey from intercepting onboarding navigation," but there is no path-based exclusion here (unlike the shouldShowCustomerSourcePrompt gating that existed earlier in this branch's history and was dropped). The card is non-blocking for routing, but it will still visually overlay the onboarding wizard and org welcome screens.


Reply with @kilocode-bot fix it to have Kilo Code address this issue.

@kilo-code-bot

kilo-code-bot Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Executive Summary

The non-blocking survey card is mounted globally in the (app) layout with no exclusion for onboarding or org-welcome routes, which runs counter to the PR's stated goal of not interfering with onboarding.

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
apps/web/src/app/(app)/layout.tsx 35 CustomerSourceSurvey renders on all (app) routes, including onboarding and org welcome, with no path exclusion
Files Reviewed (7 files)
  • apps/web/src/app/(app)/layout.tsx - 1 issue
  • apps/web/src/app/customer-source-survey/page.tsx - 0 issues
  • apps/web/src/components/CustomerSourceSurvey.tsx - 0 issues
  • apps/web/src/lib/survey-redirect.ts - 0 issues
  • apps/web/src/tests/account-verification-redirect.test.ts - 0 issues
  • apps/web/src/tests/survey-redirect.test.ts (deleted) - 0 issues
  • apps/web/tests/e2e/customer-source-survey.spec.ts (deleted) - 0 issues

Fix these issues in Kilo Cloud


Reviewed by claude-sonnet-5 · Input: 56 · Output: 22.6K · Cached: 2.6M

Review guidance: REVIEW.md from base branch main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant