feat(web): make customer survey non-blocking#4482
Conversation
| </div> | ||
| </PrefetchedOrganizations> | ||
| </SidebarProvider> | ||
| <CustomerSourceSurvey /> |
There was a problem hiding this comment.
WARNING: Survey card is not excluded from onboarding/welcome flows
<CustomerSourceSurvey /> is mounted unconditionally in the (app) layout, so it renders on every route under this layout, including /gastown/onboarding (apps/web/src/app/(app)/gastown/onboarding) and the org welcome flow (apps/web/src/app/(app)/organizations/[id]/welcome). The PR description states a goal of "stop the survey from intercepting onboarding navigation," but there is no path-based exclusion here (unlike the shouldShowCustomerSourcePrompt gating that existed earlier in this branch's history and was dropped). The card is non-blocking for routing, but it will still visually overlay the onboarding wizard and org welcome screens.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Executive SummaryThe non-blocking survey card is mounted globally in the Overview
Issue Details (click to expand)WARNING
Files Reviewed (7 files)
Fix these issues in Kilo Cloud Reviewed by claude-sonnet-5 · Input: 56 · Output: 22.6K · Cached: 2.6M Review guidance: REVIEW.md from base branch |
Summary
Moves the customer-source survey out of the onboarding path and into the authenticated app shell as a small, dismissible card. The existing persistence behavior stays the same, while the legacy survey URL now forwards users to its validated destination instead of blocking navigation.
What changed
Visual review
The UI change is contained to the authenticated survey card. This PR does not include before/after screenshot assets.
Scope
Validation
pnpm formatpnpm --filter web test -- "src/tests/account-verification-redirect.test.ts"pnpm --filter web typecheckpnpm --filter web lint