Skip to content

fix(mobile): harden isolated agent E2E workflow#4537

Merged
iscekic merged 10 commits into
mainfrom
fix/harden-mobile-agent-workflow
Jul 14, 2026
Merged

fix(mobile): harden isolated agent E2E workflow#4537
iscekic merged 10 commits into
mainfrom
fix/harden-mobile-agent-workflow

Conversation

@iscekic

@iscekic iscekic commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • make mobile dev startup worktree-safe by default, with generated endpoint env injected directly into Metro, collision checks, stable tmux pane identity, and explicit device ownership
  • make iOS login/logout deterministic across native and Expo prompts, verify the actual Metro manifest and session-ingest secret readiness, and expose stable tab accessibility labels
  • resolve Android SDK/JDK tools independently of inherited PATH and support either wrapped ADB or Maestro, while raising mobile subagent step limits

Verification

  • node --import tsx --test dev/local/services.test.ts dev/local/mobile-env.test.ts dev/local/tmux.test.ts dev/local/mobile-simulator.test.ts dev/local/mobile-workflow.test.ts
  • node --import tsx --test dev/local/env-sync/plan.test.ts
  • pnpm typecheck && pnpm lint && pnpm format:check && pnpm check:unused && pnpm test in apps/mobile (98 files, 544 tests)
  • fresh child-worktree mobile E2E: prepared env, started isolated stack, verified secret readiness and Metro manifest provenance, completed logout and fresh OTP login, asserted and tapped Agents, tab, 3 of 4, resolved Android tooling, and cleaned up without touching sibling resources

@iscekic iscekic self-assigned this Jul 14, 2026
@iscekic iscekic enabled auto-merge (squash) July 14, 2026 18:33
@iscekic iscekic merged commit a412d0e into main Jul 14, 2026
21 checks passed
@iscekic iscekic deleted the fix/harden-mobile-agent-workflow branch July 14, 2026 18:42
Comment thread apps/mobile/e2e/flows/login-request-code.yaml
Comment thread dev/local/mobile-android.ts
Comment thread dev/local/mobile-android.ts
Comment thread dev/local/mobile-simulator.ts
Comment thread dev/local/mobile-simulator.ts
Comment thread dev/local/cli.ts
Comment thread dev/local/runner.ts
Comment thread dev/local/services.test.ts
@kilo-code-bot

kilo-code-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: 8 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 8
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
apps/mobile/e2e/flows/login-request-code.yaml 17 OTP retry can get stranded on the verification screen
dev/local/mobile-android.ts 42 Partial SDK root masks later complete installations
dev/local/mobile-android.ts 150 Stale Android claim cleanup can delete a concurrent owner's lock
dev/local/mobile-simulator.ts 26 Missing/stale simulator cleanup races exclusive claim creation
dev/local/mobile-simulator.ts 104 Failed simulator boot leaks a newly acquired claim
dev/local/cli.ts 191 Any listener on port 23750 is trusted as the Docker proxy
dev/local/runner.ts 372 Restart env injection fails under supported non-POSIX shells
dev/local/services.test.ts 79 Service port assertion is tied to one worktree identity
Files Reviewed (30 files)
  • AGENTS.md - 0 issues
  • apps/mobile/.kilo/agent/mobile-e2e-verifier.md - 0 issues
  • apps/mobile/.kilo/agent/mobile-implementer.md - 0 issues
  • apps/mobile/.kilo/agent/mobile-reviewer.md - 0 issues
  • apps/mobile/e2e/AGENTS.md - 0 issues
  • apps/mobile/e2e/flows/login-request-code.yaml - 1 issue
  • apps/mobile/e2e/flows/login-verify-code.yaml - 0 issues
  • apps/mobile/e2e/flows/logout.yaml - 0 issues
  • apps/mobile/e2e/flows/open-app.yaml - 0 issues
  • apps/mobile/e2e/flows/settle-app.yaml - 0 issues
  • apps/mobile/e2e/login.sh - 0 issues
  • apps/mobile/e2e/logout.sh - 0 issues
  • apps/mobile/e2e/preflight.sh - 0 issues
  • apps/mobile/src/app/(app)/(tabs)/_layout.tsx - 0 issues
  • dev/local/cli.ts - 1 issue
  • dev/local/env-sync/index.ts - 0 issues
  • dev/local/env-sync/output.ts - 0 issues
  • dev/local/env-sync/plan.test.ts - 0 issues
  • dev/local/env-sync/plan.ts - 0 issues
  • dev/local/mobile-android.ts - 2 issues
  • dev/local/mobile-env.test.ts - 0 issues
  • dev/local/mobile-env.ts - 0 issues
  • dev/local/mobile-simulator.test.ts - 0 issues
  • dev/local/mobile-simulator.ts - 2 issues
  • dev/local/mobile-workflow.test.ts - 0 issues
  • dev/local/runner.ts - 1 issue
  • dev/local/services.test.ts - 1 issue
  • dev/local/services.ts - 0 issues
  • dev/local/tmux.test.ts - 0 issues
  • dev/local/tmux.ts - 0 issues
  • package.json - 0 issues
  • scripts/worktree-prepare.sh - 0 issues

Fix these issues in Kilo Cloud


Reviewed by gpt-5.6-sol · Input: 244.6K · Output: 32.9K · Cached: 2.9M

Review guidance: REVIEW.md from base branch main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants