fix: add Enter key to trigger active primary buttons#85
Closed
patrickoleary wants to merge 1 commit intoKitware:masterfrom
Closed
fix: add Enter key to trigger active primary buttons#85patrickoleary wants to merge 1 commit intoKitware:masterfrom
patrickoleary wants to merge 1 commit intoKitware:masterfrom
Conversation
Collaborator
|
Wrong solution, the various places where we expect "enter" to validate current action should handle it locally with the standard event binding of vue. |
Member
Author
|
No I tried that. It won't work because it doesn't have focus. so you can't do it locally. |
Collaborator
|
Make the field or button in focus |
Collaborator
|
And if you don't want to have anything in focus and just handle "enter", then you should use our current set of keyboard shortcut here |
7616e49 to
8d21952
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add global Enter key support that routes to the currently active primary action button.
Each action respects the same disabled conditions as its button
closes #79